geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sachin Patel <sppat...@gmail.com>
Subject Re: [Vote: RTC] needed for eclipse plugin
Date Thu, 01 Jun 2006 17:13:24 GMT
No reason.  Thought it was easier to follow.  I don't have a problem  
adding setters, thx for the suggestion! :)

On Jun 1, 2006, at 1:01 PM, David Jencks wrote:

> +1 to committing this.
>
> I wondered why there are separate dependency and import wizards?   
> It looks like just some titles are different, would it be  
> appropriate to have just one wizard in which you can set the import  
> element if appropriate?
>
> thanks
> david jencks
>
>
> On Jun 1, 2006, at 6:42 AM, Sachin Patel wrote:
>
>> The following big change is part 1 of 2 to correctly handle  
>> loading of the deployment plan editors.  To briefly summarize, the  
>> change introduces a new extension point which requires an  
>> implementation of IGeronimoFormContentLoader.  Previously the  
>> editor extension point loaded the editor for 1.0 plans.  Now the  
>> editor must handle multiple versions of the deployment plans so  
>> now there is a single editor extension def which loads a single  
>> editor impl, SharedDeploymentEditor which loads all the  
>> IGeronimoFormContent loaders (one impl for 1.0 and another for  
>> 1.1) and delegates to the appropriate emf models to generate the  
>> UI for the plans.  With this commit, the 1.0 plans load correctly  
>> and there is some work still need to be done for 1.1 to be done.   
>> There is currently some duplicate code which will need to be  
>> refactored, part 2 will address this, but since the patch is about  
>> 3000 lines I wanted to go ahead and commit.
>>
>> Please vote...
>>
>> Thanks.
>> <patch2.txt>
>>
>> -sachin
>>
>>
>


-sachin



Mime
View raw message