geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Mulder (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-1492) Many "org/apache/geronimo" configIds still live in source tree
Date Fri, 02 Jun 2006 13:38:30 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-1492?page=comments#action_12414418 ] 

Aaron Mulder commented on GERONIMO-1492:
----------------------------------------

I have two issues with this patch.

1) In the patch for the startup monitor, it removes the logic that avoids listing the system
database pool, etc.  I think that needs more thought and we shouldn't change the behavior
as part of this patch.  So I think it should be changed to check for name starts with geronimo/system
or whatever instead of org/apache/geronimo/System instead of removing the check.

2) There are sections like the one below in many of the files.  I'm not convinced this is
correct syntax.  Is it legal to list only part of a module name in a module element in a reference?

         <reference name="ServerInfo">
-            <module>org/apache/geronimo/System</module>
+            <module>geronimo/j2ee-system</module>
             <name>ServerInfo</name>
         </reference>


> Many "org/apache/geronimo" configIds still live in source tree
> --------------------------------------------------------------
>
>          Key: GERONIMO-1492
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1492
>      Project: Geronimo
>         Type: Bug
>     Security: public(Regular issues) 
>     Versions: 1.0
>     Reporter: Aaron Mulder
>     Priority: Blocker
>      Fix For: 1.1
>  Attachments: GERONIMO-1492.diff, annotated-grep-output.txt
>
> I created a couple separate issues, but beyond those a quick search brought up a few
more in magic G ball and day trader -- I stopped before it went any further, but we should
grep for that and try to eliminate all the references to old-style config IDs.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message