geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dain Sundstrom (JIRA)" <>
Subject [jira] Updated: (GERONIMO-1960) Bad GBean reference isn't caught during deployment
Date Wed, 24 May 2006 02:46:30 GMT
     [ ]

Dain Sundstrom updated GERONIMO-1960:

    Attachment: 1960.patch

NOTE: This patch needs further discussion on the dev list before it can be applied (see the
last item)...

I added a verify method to Deployment context which is called from getConfigurationData().
 This method verifies the references and dependencies on can be resolved.  I only try to resolve
dependencies and single valued references. Further, only unresolved reference patterns are
resolved, under the assumption that the deployer created a resolved pattern correctly.   We
can not absolute references to beans in external modules.

This patch includes a minor change to ConnectorModuleBuilderTest to cause it to create an
EARContext that can resolve references (since they are now resolved during deployment).

There is also a related patch to SingleElementCollection to cause it to not throw an exception
when a null collection is passed in.  This matches the behavior of the other constructor.

Removed the unnecessary and possibly incorrect module declarations in configs/client-security/src/plan/plan.xml.

Commented out dependency in configs/client-corba/src/plan/plan.xml to SecurityService as it
can not be resolved since there is no dependency on client-security.  

> Bad GBean reference isn't caught during deployment
> --------------------------------------------------
>          Key: GERONIMO-1960
>          URL:
>      Project: Geronimo
>         Type: Bug
>     Security: public(Regular issues) 
>   Components: deployment, kernel
>     Versions: 1.1
>     Reporter: Aaron Mulder
>     Assignee: Dain Sundstrom
>     Priority: Blocker
>      Fix For: 1.1
>  Attachments: 1960.patch, filestore.jar, geronimo-service.xml, geronimo-service.xml
> If you deploy the attached JAR and plan, it is distributed successfully but fails during
startup when the GBean in the plan can't find ServerInfo.  This is not correct behavior --
we should fail during distribute if there are bad GBean references.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message