geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Genender <jgenen...@apache.org>
Subject Re: Re-migration to m2 - status and discussion.
Date Thu, 01 Jun 2006 04:54:15 GMT
Prasad,

If you really need to use the jspc plugin now, please use version 1.4.3.
 It does not fork the compile.

Jeff

Prasad Kashyap wrote:
> The migration of applications to M2 has been kinda held up by the
> following 2 maven jiras
> 
> http://jira.codehaus.org/browse/MJSPC-2 (to fix jspc plugin)
> http://jira.codehaus.org/browse/MWAR-45 (to fix jar'ing classes to
> web-inf/lib).
> 
> I have submitted a patch for the latter (maven-war-plugin, mwar-45).
> 
> Soon, I shall submit a patch for the application migration without
> these 2 features (jsp precompile and jar classes). We can do good w/o
> these for now. Once the maven jiras are ready, we shall patch the
> application pom(s) again.
> 
> Cheers
> Prasad
> 
> 
> On 5/31/06, Prasad Kashyap <goyathlay.geronimo@gmail.com> wrote:
>> Thanx Jeff. Please see comments inline -
>>
>> Cheers
>> Prasad
>>
>> On 5/31/06, Jeff Genender <jgenender@apache.org> wrote:
>> > Prasad,
>> >
>> > I can fix #1.  I need to dig up some old code from the 1.4.3 version. I
>> > converted to a forked version because it really lightened the amount of
>> > code in the plugin.  But I have heard of this being an issue, so I may
>> > fatten the plugin up a little bit and force a call to javac once again.
>> >  Could you be kind enough to open a JIRA on the forking problem on Mojo
>> > for the jspc-plugin so I can track this?
>>
>> http://jira.codehaus.org/browse/MJSPC-2
>>
>> >
>> > #2 needs a bit more thought.  I am not sure if the existence of a
>> > web.xml is the way to go on this one.
>>
>> What say we look for the <packaging> element in the pom.xml ? Make
>> this plugin relevant only for "war" packagings and skip it for others.
>> http://jira.codehaus.org/browse/MJSPC-3.
>>
>> >
>> > Jeff
>> >
>> > Prasad Kashyap wrote:
>> > > I have all the applications migrated to M2 now. But I have a problem
>> > > using the jspc-maven-plugin to precompile the JSPs. I hope Jeff can
>> > > help me here.
>> > >
>> > > The jspc-maven-plugin is configured in the parent pom and executed by
>> > > the pom in each application. Please find attached the parent pom
>> (goes
>> > > in geronimo/application dir) and a pom from uddi-db application (goes
>> > > in geronimo/application/uddi-db dir).
>> > >
>> > > Here are the problems.
>> > > 1. Using the the jspc-maven-plugin makes it execute the other plugins
>> > > in the pom twice. I guess this is being caused when the lifecycle is
>> > > forked. See the attached mvn.log from the uddi-db app. How can I get
>> > > around it ?
>> > >
>> > > 2. It will be nice if I can specify the execution of the
>> > > jspc-maven-plugin "compile" goal once in the parent pom. The mojo
>> > > should check for the existence of web-inf or web.xml file. If it
>> > > doesn't exist, it should skip gracefully (MojoFailureException ?).
>> > > This way we can just invoke the jspc mojo in the parent pom and not
>> > > have to invoke it every war child.
>> > >
>> > > Cheers
>> > > Prasad
>> > >
>> > > On 5/30/06, Guillaume Nodet <guillaume.nodet@worldonline.fr> wrote:
>> > >> Snapshots are not uploaded on public repos.
>> > >> But they are available at
>> > >>
>> > >>
>> http://people.apache.org/maven-snapshot-repository/org/apache/geronimo/specs/geronimo-j2ee_1.4_spec/1.1-SNAPSHOT/
>>
>> > >>
>> > >>
>> > >> Cheers,
>> > >> Guillaume Nodet
>> > >>
>> > >> anita kulshreshtha wrote:
>> > >>
>> > >> >
>> > >> >     I wish it was true! Prasad has agreed ;) to take care of the
>> > >> >applications and the assembly plugin.
>> > >> >
>> > >> >P.S. How do I get geronimo-j2ee_1.4_spec-1.1-SNAPSHOT.jar to
>> this or
>> > >> >any other m2 repo ?
>> > >>
>> >http://repo.mergere.com/maven2/org/apache/geronimo/specs/geronimo-j2ee_1.4_spec/
>>
>> > >>
>> > >> >
>> > >> >
>> > >> >Thanks
>> > >> >Anita
>> > >> >
>> > >> >
>> > >> >
>> > >> >
>> > >> >
>> > >>
>> > >
>> > >
>> ------------------------------------------------------------------------
>> > >
>> > > <?xml version="1.0" encoding="UTF-8"?>
>> > > <!--
>> > >
>> > >     Copyright 2006 The Apache Software Foundation
>> > >
>> > >     Licensed under the Apache License, Version 2.0 (the "License");
>> > >     you may not use this file except in compliance with the License.
>> > >     You may obtain a copy of the License at
>> > >
>> > >        http://www.apache.org/licenses/LICENSE-2.0
>> > >
>> > >     Unless required by applicable law or agreed to in writing,
>> software
>> > >     distributed under the License is distributed on an "AS IS" BASIS,
>> > >     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
>> or implied.
>> > >     See the License for the specific language governing
>> permissions and
>> > >     limitations under the License.
>> > > -->
>> > >
>> > > <!-- $Rev: 386910 $ $Date: 2006-03-18 21:13:26 -0500 (Sat, 18 Mar
>> 2006) $ -->
>> > >
>> > > <project>
>> > >   <parent>
>> > >     <groupId>org.apache.geronimo</groupId>
>> > >     <artifactId>geronimo-parent</artifactId>
>> > >     <version>1.2-SNAPSHOT</version>
>> > >   </parent>
>> > >
>> > >   <modelVersion>4.0.0</modelVersion>
>> > >   <groupId>org.apache.geronimo.applications</groupId>
>> > >   <artifactId>applications-parent</artifactId>
>> > >   <version>${geronimoVersion}</version>
>> > >   <packaging>pom</packaging>
>> > >   <name>Geronimo Applications</name>
>> > >   <description>Geronimo Applications</description>
>> > >
>> > >   <build>
>> > >     <plugins>
>> > >       <plugin>
>> > >         <artifactId>maven-war-plugin</artifactId>
>> > >         <configuration>
>> > >          
>> <warSourceDirectory>${basedir}/src/webapp</warSourceDirectory>
>> > >           <webXml>${basedir}/target/jspweb.xml</webXml>
>> > >         </configuration>
>> > >       </plugin>
>> > >       <plugin>
>> > >         <groupId>org.codehaus.mojo</groupId>
>> > >         <artifactId>jspc-maven-plugin</artifactId>
>> > >         <configuration>
>> > >          
>> <warSourceDirectory>${basedir}/src/webapp</warSourceDirectory>
>> > >          
>> <inputWebXml>${basedir}/src/webapp/WEB-INF/web.xml</inputWebXml>
>> > >         </configuration>
>> > >       </plugin>
>> > >     </plugins>
>> > >   </build>
>> > >
>> > >   <dependencies>
>> > >     <dependency>
>> > >         <groupId>tomcat</groupId>
>> > >         <artifactId>jasper-runtime</artifactId>
>> > >         <version>${jasperVersion}</version>
>> > >     </dependency>
>> > >   </dependencies>
>> > >
>> > >
>> > >   <modules>
>> > >     <module>demo</module>
>> > >     <module>ldap-realm-demo</module>
>> > >     <module>magicGball</module>
>> > >     <!-- module>remote-deploy</module  -->
>> > >     <module>uddi-db</module>
>> > >     <module>uddi-server</module>
>> > >     <module>console</module>
>> > >     <module>welcome</module>
>> > >   </modules>
>> > > </project>
>> > >
>> > >
>> > >
>> ------------------------------------------------------------------------
>> > >
>> > > <?xml version="1.0" encoding="UTF-8"?>
>> > > <!--
>> > >
>> > >     Copyright 2006 The Apache Software Foundation
>> > >
>> > >     Licensed under the Apache License, Version 2.0 (the "License");
>> > >     you may not use this file except in compliance with the License.
>> > >     You may obtain a copy of the License at
>> > >
>> > >        http://www.apache.org/licenses/LICENSE-2.0
>> > >
>> > >     Unless required by applicable law or agreed to in writing,
>> software
>> > >     distributed under the License is distributed on an "AS IS" BASIS,
>> > >     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
>> or implied.
>> > >     See the License for the specific language governing
>> permissions and
>> > >     limitations under the License.
>> > > -->
>> > >
>> > > <!-- $Rev: 386910 $ $Date: 2006-03-18 21:13:26 -0500 (Sat, 18 Mar
>> 2006) $ -->
>> > >
>> > > <project>
>> > >   <parent>
>> > >     <groupId>org.apache.geronimo.applications</groupId>
>> > >     <artifactId>applications-parent</artifactId>
>> > >     <version>1.2-SNAPSHOT</version>
>> > >   </parent>
>> > >
>> > >   <modelVersion>4.0.0</modelVersion>
>> > >   <artifactId>geronimo-uddi-db</artifactId>
>> > >   <version>${geronimoVersion}</version>
>> > >   <name>Geronimo UDDI Server Database</name>
>> > >   <description>Geronimo UDDI Server Database</description>
>> > >
>> > >   <build>
>> > >
>> > >
>> > >     <resources>
>> > >       <resource>
>> > >         <!-- ${project.build.directory} doesn't work in the
>> following line. -->
>> > >         <directory>${basedir}/target/resources</directory>
>> > >       </resource>
>> > >     </resources>
>> > >
>> > >
>> > >     <plugins>
>> > >       <plugin>
>> > >         <artifactId>maven-antrun-plugin</artifactId>
>> > >         <executions>
>> > >           <execution>
>> > >             <phase>generate-resources</phase>
>> > >             <configuration>
>> > >               <tasks>
>> > >                 <property name="derby.system.home"
>> value="${project.build.directory}/resources/META-INF/${pom.artifactId}/var/derby"/>
>>
>> > >                 <property
>> name="derby.storage.fileSyncTransactionLog" value="true"/>
>> > >                 <delete dir="${derby.system.home}"/>
>> > >                 <mkdir dir="${derby.system.home}"/>
>> > >                 <sql driver="org.apache.derby.jdbc.EmbeddedDriver"
>> > >                  
>> url="jdbc:derby:${derby.system.home}/UddiDatabase;create=true"
>> > >                   userid="" password="" autocommit="true"
>> onerror="abort" delimiter=";">
>> > >                   <fileset dir="src/sql"/>
>> > >                   <classpath>
>> > >                     <fileset
>> dir="${settings.localRepository}/org/apache/derby/derby/${derbyVersion}">
>> > >                       <include name="**/derby-${derbyVersion}.jar" />
>> > >                     </fileset>
>> > >                   </classpath>
>> > >                 </sql>
>> > >               </tasks>
>> > >             </configuration>
>> > >             <goals>
>> > >               <goal>run</goal>
>> > >             </goals>
>> > >           </execution>
>> > >         </executions>
>> > >       </plugin>
>> > >       <plugin>
>> > >         <groupId>org.codehaus.mojo</groupId>
>> > >         <artifactId>jspc-maven-plugin</artifactId>
>> > >         <executions>
>> > >           <execution>
>> > >               <id>jspc</id>
>> > >               <goals>
>> > >                   <goal>compile</goal>
>> > >               </goals>
>> > >             </execution>
>> > >         </executions>
>> > >         <configuration>
>> > >          
>> <warSourceDirectory>${basedir}/src/webapp</warSourceDirectory>
>> > >          
>> <inputWebXml>${basedir}/src/webapp/WEB-INF/web.xml</inputWebXml>
>> > >         </configuration>
>> > >       </plugin>
>> > >     </plugins>
>> > >   </build>
>> > >
>> > >   </project>
>> >
>>

Mime
View raw message