geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Kashyap (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-1900) Sample app links on welcome app are broken by default
Date Mon, 15 May 2006 14:47:06 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-1900?page=comments#action_12402322 ] 

Prasad Kashyap commented on GERONIMO-1900:
------------------------------------------

The requirements sought in this thread -
http://www.mail-archive.com/dev@geronimo.apache.org/msg22100.html and it's subsequent discussions

necessitated the use of 2 servlets, changes to existing JSPs, adding new JSPs and image.
One servlet that installs the samples is secured and thus every attempt to install an example
is authenticated. 
The other servlet serves the sample, redirects to the console to start a stopped sample, or
install it if it has been removed. This servlet has no security constraints. Hence we needed
2 servlets.

The new JSPs added were the login.jsp and login_error.jsp. I don't see how we can get rid
of this if we want to authenticate the user before (s)he installs the examples.

The only new image added was to have a generic header gif. The gifs in other apps had Console,
Server Info etc etched into it.  Those gifs could not be reused.

Comments about Javadoc, variable notation convention, and 1 unused string constant are well
taken. I shall clean up the code appropriately.

The instance variables are initialized by the servlet's init() once and used by others per
request. I'm amenable to any suggestions.

> Sample app links on welcome app are broken by default
> -----------------------------------------------------
>
>          Key: GERONIMO-1900
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1900
>      Project: Geronimo
>         Type: Bug
>     Security: public(Regular issues) 
>   Components: usability, sample apps
>     Versions: 1.1
>     Reporter: Aaron Mulder
>     Assignee: Aaron Mulder
>     Priority: Blocker
>      Fix For: 1.1
>  Attachments: logo_head_570x86.gif, welcome-10.patch, welcome-2.patch, welcome-3.patch,
welcome-4.patch, welcome-6.patch, welcome-7.patch, welcome-8.patch, welcome-9.patch, welcome-images.jar,
welcome-images.zip, welcome.patch
>
> It would be nice to take users to a page that would prompt them to install the sample
if they click a link to it and it's not present. However, automating this would require us
to be able to construct a link into a portlet, which does not seem easy. 
> For now, the welcome app can include pages at the locations where the sample apps will
be bound, with text to the effect of: 
> This sample has not yet been installed. To install it, visit the (URL)console(/URL) and
select the Plugins page, click the Search for Plugins button, and select the (NAME HERE) sample
to install. Then visit this same URL again to view the (NAME HERE) example.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message