geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Mulder (JIRA)" <>
Subject [jira] Commented: (GERONIMO-1900) Sample app links on welcome app are broken by default
Date Sun, 14 May 2006 21:11:06 GMT
    [ ] 

Aaron Mulder commented on GERONIMO-1900:

OK, looking at patch 9...

I still am not thrilled with this.  In no particular order:
 - it seems too complex for what we're doing: multiple servlets, new images, changes to existing
JSPs, new JSPs...
 - The JavaDoc is not up to date
 - There are string constants that do not seem to be up to date
 - Some variables are in camel case, others use underscores
 - The login page has a table with over 30 cells to hold username, password, and submit
 - The servlets aren't just mapped to the URLs where the sample apps will appear, making the
whole thing more complex less transparent
 - I don't like servlets with tons of instance variables

Let's back up and think about the best way to proceed here.

> Sample app links on welcome app are broken by default
> -----------------------------------------------------
>          Key: GERONIMO-1900
>          URL:
>      Project: Geronimo
>         Type: Bug
>     Security: public(Regular issues) 
>   Components: usability, sample apps
>     Versions: 1.1
>     Reporter: Aaron Mulder
>     Assignee: Aaron Mulder
>     Priority: Blocker
>      Fix For: 1.1
>  Attachments: logo_head_570x86.gif, welcome-10.patch, welcome-2.patch, welcome-3.patch,
welcome-4.patch, welcome-6.patch, welcome-7.patch, welcome-8.patch, welcome-9.patch, welcome-images.jar,, welcome.patch
> It would be nice to take users to a page that would prompt them to install the sample
if they click a link to it and it's not present. However, automating this would require us
to be able to construct a link into a portlet, which does not seem easy. 
> For now, the welcome app can include pages at the locations where the sample apps will
be bound, with text to the effect of: 
> This sample has not yet been installed. To install it, visit the (URL)console(/URL) and
select the Plugins page, click the Search for Plugins button, and select the (NAME HERE) sample
to install. Then visit this same URL again to view the (NAME HERE) example.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message