geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul McMahan (JIRA)" <...@geronimo.apache.org>
Subject [jira] Updated: (GERONIMO-1889) Changing pooling parameters for connector does not persist to config.xml
Date Thu, 04 May 2006 20:32:25 GMT
     [ http://issues.apache.org/jira/browse/GERONIMO-1889?page=all ]

Paul McMahan updated GERONIMO-1889:
-----------------------------------

    Attachment: GERONIMO-1889.patch

In addition to the dbpools there are three other types of changes in the console that are
not persisted across server restart:
changes to the JMS connectors
changes to the security realms
changes to the web connectors

The problem is that gbeans that don't already have a corresponding entry in the config.xml
are not getting persisted  The attached patch forces the LocalAttributeManager to write the
config changes for those objects out to config.xml when they are changed.  If there's a more
generic approach that's cleaner then let me know and I'll rework the patch.

NOTE:
I updated GBeanOverride to check the overridden attributes for null before calling .value()
on them.  If the attribute is null then I skip it (the attribute is not written to config.xml).
 Without this change I was getting a NPE when trying to do things like update the attributes
of an HTTPS connector since some of its attributes are null. I seem to recall a change going
into 1.2 to handle null attributes in a special way but I didn't want to introduce that type
of change at this point in 1.1 without further guidance.

> Changing pooling parameters for connector does not persist to config.xml
> ------------------------------------------------------------------------
>
>          Key: GERONIMO-1889
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1889
>      Project: Geronimo
>         Type: Bug
>     Security: public(Regular issues) 
>   Components: connector, kernel, console
>     Versions: 1.1
>     Reporter: Aaron Mulder
>     Assignee: Paul McMahan
>     Priority: Blocker
>      Fix For: 1.1
>  Attachments: GERONIMO-1889.patch
>
> To replicate:
> Open the console
> Select Database Pools
> Click the "edit" link to the right of "System Datasource"
> Change pool max size to 119
> Click Save
> Click the "edit" link to the right of "System Datasource"
> Confirm that it shows a pool max size of 119
> Shut down the server
> Grep config.xml for 119, it does not appear
> Start the server
> Edit the System Datasource again, confirm that the pool max size is NOT 119
> Also need to check whether changing the data connection properties is persisted.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message