Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 92437 invoked from network); 25 Apr 2006 13:43:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 25 Apr 2006 13:43:53 -0000 Received: (qmail 64150 invoked by uid 500); 25 Apr 2006 13:41:42 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 63783 invoked by uid 500); 25 Apr 2006 13:41:40 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 63772 invoked by uid 99); 25 Apr 2006 13:41:40 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Apr 2006 06:41:40 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of ammulder@gmail.com designates 64.233.166.183 as permitted sender) Received: from [64.233.166.183] (HELO pproxy.gmail.com) (64.233.166.183) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Apr 2006 06:41:39 -0700 Received: by pproxy.gmail.com with SMTP id t32so1289767pyc for ; Tue, 25 Apr 2006 06:41:18 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=gqWxtdnQ38b6BhiuoL6ZuuYKEwyF7zZ7Gq6fcfhKwUm1iBriWmnhszoSGF3w0Z1g1b/3OP6P3Ll74THkdmdRvGTh9jk3ZyIqvZ0a3IKti4Z2PMj+1nrl7uGkbYe1oXHJRpEx6GoTwx9PNZGSU/1F5umTSv1EWwp0oYy2KiMJnmM= Received: by 10.35.91.10 with SMTP id t10mr2631730pyl; Tue, 25 Apr 2006 06:41:18 -0700 (PDT) Received: by 10.35.116.1 with HTTP; Tue, 25 Apr 2006 06:41:18 -0700 (PDT) Message-ID: <74e15baa0604250641m7b7d99b0q49e1584b7cc896c7@mail.gmail.com> Date: Tue, 25 Apr 2006 09:41:18 -0400 From: "Aaron Mulder" Sender: ammulder@gmail.com To: dev@geronimo.apache.org Subject: Re: svn commit: r396880 - in /geronimo/branches/1.1/modules: jetty/src/test/org/apache/geronimo/jetty/AbstractWebModuleTest.java tomcat/src/test/org/apache/geronimo/tomcat/AbstractWebModuleTest.java In-Reply-To: <20060425132750.85181.qmail@minotaur.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20060425132750.85181.qmail@minotaur.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Oops, guess I forgot to run a full set of tests. :) Thanks! Aaron On 4/25/06, kevan@apache.org wrote: > Author: kevan > Date: Tue Apr 25 06:26:04 2006 > New Revision: 396880 > > URL: http://svn.apache.org/viewcvs?rev=3D396880&view=3Drev > Log: > Fix test failures caused by revision 396767 > > Modified: > geronimo/branches/1.1/modules/jetty/src/test/org/apache/geronimo/jett= y/AbstractWebModuleTest.java > geronimo/branches/1.1/modules/tomcat/src/test/org/apache/geronimo/tom= cat/AbstractWebModuleTest.java > > Modified: geronimo/branches/1.1/modules/jetty/src/test/org/apache/geronim= o/jetty/AbstractWebModuleTest.java > URL: http://svn.apache.org/viewcvs/geronimo/branches/1.1/modules/jetty/sr= c/test/org/apache/geronimo/jetty/AbstractWebModuleTest.java?rev=3D396880&r1= =3D396879&r2=3D396880&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- geronimo/branches/1.1/modules/jetty/src/test/org/apache/geronimo/jett= y/AbstractWebModuleTest.java (original) > +++ geronimo/branches/1.1/modules/jetty/src/test/org/apache/geronimo/jett= y/AbstractWebModuleTest.java Tue Apr 25 06:26:04 2006 > @@ -48,7 +48,7 @@ > > > /** > - * @version $Rev: 386763 $ $Date$ > + * @version $Rev$ $Date$ > */ > public class AbstractWebModuleTest extends TestCase { > protected ClassLoader cl; > @@ -185,7 +185,7 @@ > > configurationBaseURL =3D cl.getResource("deployables/"); > > - container =3D new JettyContainerImpl("test:name=3DJettyContainer= "); > + container =3D new JettyContainerImpl("test:name=3DJettyContainer= ", null); > container.doStart(); > connector =3D new HTTPConnector(container); > connector.setPort(5678); > > Modified: geronimo/branches/1.1/modules/tomcat/src/test/org/apache/geroni= mo/tomcat/AbstractWebModuleTest.java > URL: http://svn.apache.org/viewcvs/geronimo/branches/1.1/modules/tomcat/s= rc/test/org/apache/geronimo/tomcat/AbstractWebModuleTest.java?rev=3D396880&= r1=3D396879&r2=3D396880&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- geronimo/branches/1.1/modules/tomcat/src/test/org/apache/geronimo/tom= cat/AbstractWebModuleTest.java (original) > +++ geronimo/branches/1.1/modules/tomcat/src/test/org/apache/geronimo/tom= cat/AbstractWebModuleTest.java Tue Apr 25 06:26:04 2006 > @@ -174,7 +174,7 @@ > engine.doStart(); > > ServerInfo serverInfo =3D new BasicServerInfo("."); > - container =3D new TomcatContainer(cl, "target/var/catalina", eng= ine, serverInfo, null); > + container =3D new TomcatContainer(cl, "target/var/catalina", eng= ine, serverInfo, null, null); > container.doStart(); > > connector =3D new ConnectorGBean("HTTP", null, "localhost", 8181= , container); > > >