Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 33944 invoked from network); 15 Apr 2006 01:04:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 15 Apr 2006 01:04:30 -0000 Received: (qmail 67523 invoked by uid 500); 15 Apr 2006 01:04:26 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 67483 invoked by uid 500); 15 Apr 2006 01:04:26 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 67467 invoked by uid 99); 15 Apr 2006 01:04:26 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Apr 2006 18:04:26 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of jrsisson@gmail.com designates 64.233.162.206 as permitted sender) Received: from [64.233.162.206] (HELO nz-out-0102.google.com) (64.233.162.206) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Apr 2006 18:04:25 -0700 Received: by nz-out-0102.google.com with SMTP id l8so187617nzf for ; Fri, 14 Apr 2006 18:04:04 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding; b=NKUDs4gdNZgGCUuyZXYOj57Gioqeea7h3HcF/zGFjQBoR3f4Bk9+tapf0KcNPLnJDahw3BLGitwxmf4aNMPKr3c1h0BnQuDeVr/oRUAAu4zGUXkQ0XNp2tzu89h5DdmhOyDXgTv1FCXkLMpOhX/ezu4P/UrDy3iDHWoLc6heh74= Received: by 10.36.221.47 with SMTP id t47mr3030530nzg; Fri, 14 Apr 2006 18:04:04 -0700 (PDT) Received: from ?192.168.0.23? ( [59.167.14.84]) by mx.gmail.com with ESMTP id 37sm798724nzf.2006.04.14.18.04.02; Fri, 14 Apr 2006 18:04:04 -0700 (PDT) Message-ID: <4440466E.4030102@gmail.com> Date: Sat, 15 Apr 2006 11:03:42 +1000 From: John Sisson User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: dev@geronimo.apache.org Subject: Re: Update on Long Paths References: <3FE6C201-ED50-458F-9992-0E48DB8FC4B5@iq80.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N It would be good if we could use precompiled jsps so the server is always responsive - that first time hit often happens when you are running a demo :-) John Prasad Kashyap wrote: > I could not use the ant task to precompile jsps. Using the following, > simply nothing happens. > > classpathref="jspc.classpath"/> > webXmlFragment="${webroot}/generated_web.xml" addWebXmlMappings="true" > outputDir="${outDir}" /> > > So by passing a few more args to our existing execution, I > was able to generate the xml file too. Using the option > addWebXmlMappings, I tried to merge the web.xmls but JspC cried that > it was a unrecognized option. > > > > Looking at the JspC code, > http://svn.apache.org/repos/asf/tomcat/jasper/branches/tc5.0.x/jasper2/src/share/org/apache/jasper/JspC.java > it seems like you can't pass addWebXmlMappings in a java command line > argument. It is not recognized or set by the setArgs(). Seems like a > jasper bug ? > > So I added another goal to our deployment plugin called "mergeWebXML". > This goal merges the generated web.xml fragment with the existing one > from source. > > When I spoke to the Tomcat guys, they feel that precompiling JSPs > doesn't buy us anything anymore, except for that first time hit. The > request mapper is supposedly fixed in 5.5.x versions and thus we > shouldn't see any other performance hit. > > Anyways, I have uploaded the patch to > http://issues.apache.org/jira/browse/GERONIMO-1844 > > Cheers > Prasad > > > > > > On 4/14/06, Prasad Kashyap wrote: > >> OK. I'll take care of the JSP pages. I am done with jar'ing the >> generated class files. I shall look into generating a web.xml and >> merging it. >> >> Cheers >> Prasad >> >> On 4/13/06, Dain Sundstrom wrote: >> >>> Prasad got the patch working on all web applications. The next big >>> offenders left are the auto generated WebServices wrapper class and >>> the precompiled JSP pages. David Jencks has a patch for the >>> WebServices class, but we are waiting to get the TCK running so we >>> can judge the impact. I disabled precompiled JSP pages, as they >>> didn't work anyway. We generate the classes and compile them, but we >>> never added them to the class path and we are not merging generated- >>> web.xml into our web.xml. I'm hoping Prasad has time to tackle this >>> one. >>> >>> With these patches in, except for the WS class, the longest paths >>> including server name is 224 and 217 characters: >>> >>> geronimo-1.1-SNAPSHOT/repository/geronimo/daytrader-derby-jetty- >>> streamer-client/1.1-SNAPSHOT/daytrader-derby-jetty-streamer- >>> client-1.1-SNAPSHOT.car/activemq/activemq-ra/3.2.4-SNAPSHOT/rar/ >>> activemq-optional-3.2.4-SNAPSHOT.jar >>> geronimo-1.1-SNAPSHOT/repository/geronimo/webconsole-jetty/1.1- >>> SNAPSHOT/webconsole-jetty-1.1-SNAPSHOT.car/geronimo-console- >>> framework-1.1-SNAPSHOT.war/WEB-INF/config/services/ >>> PortletDefinitionRegistryService.properties >>> >>> These will become 179 and 189 characters when we drop -SNAPSHOT from >>> all of the version numbers. I'm also hoping we can change the name >>> daytrader-derby-jetty-streamer-client to something shorter. >>> >>> This is a lot better and will allow for at least 50 characters of >>> head room, which I hope is plenty for windows users. >>> >>> >>> As for next steps, I'd like to get the hot deploy service working >>> better. With the addition of the in-place deployment feature from >>> Gianny and the timestamp I added to the configuration, we should be >>> able to write a much better service. Once we have the better hot >>> deploy service, we will be able to implement the flat deployment >>> model that Hernan and others have suggested. >>> >>> -dain >>> >>> >>> >>> >>> >>> >>> >>> > >