Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 9007 invoked from network); 1 Mar 2006 11:56:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Mar 2006 11:56:50 -0000 Received: (qmail 33401 invoked by uid 500); 1 Mar 2006 11:57:33 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 33346 invoked by uid 500); 1 Mar 2006 11:57:33 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 33335 invoked by uid 99); 1 Mar 2006 11:57:33 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2006 03:57:33 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [211.29.132.182] (HELO mail01.syd.optusnet.com.au) (211.29.132.182) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2006 03:57:32 -0800 Received: from [127.0.0.1] (d220-236-201-216.dsl.nsw.optusnet.com.au [220.236.201.216]) (authenticated sender gianny.damour) by mail01.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id k21BulM0021172 for ; Wed, 1 Mar 2006 22:57:10 +1100 Message-ID: <44058BFB.7030801@optusnet.com.au> Date: Wed, 01 Mar 2006 22:56:43 +1100 From: Gianny Damour User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@geronimo.apache.org Subject: ModuleBuilder - add initENC after addGBeans Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi, I think that we need to split ModuleBuilder.addGBeans into two methods: addGBeans and initENC. addGBeans implementations perform GBean registrations as per the current approach. initENC is invoked after the addGBeans phase and implementations use this callback to build the ENC. The issue with the current implementation is that it is impossible to bind a GBean reference to the ENC if the referenced GBean is defined by a module which has not yet been processed by addGBeans. For instance, if a module A references a GBean added by a module B and if module A is processed before module B, then it is impossible to locate the referenced GBean as it has not yet been added to the registry. If there is no objection, I will start to work on it in the next couple of days. Thanks, Gianny