Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <2087140640.1142867760833.JavaMail.jira@ajax>
Date: Mon, 20 Mar 2006 15:16:00 +0000 (GMT)
From: "Jacek Laskowski (JIRA)" <dev@geronimo.apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMO-1754) Add GBeans for configuring
 NNTPTransport and NNTPStore access
In-Reply-To: <744205306.1142864818288.JavaMail.jira@ajax>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/GERONIMO-1754?page=comments#action_12371094 ] 

Jacek Laskowski commented on GERONIMO-1754:
-------------------------------------------

Committed revision 387218. Thanks Rick!

Some comments:
 * The ASL header should contain 'Copyright 2006' rather than 'Copyright 2004' (fixed)
 * Why do you use literal strings rathen than constants, e.g. mail.nntp.quitwait - it's less error-prone

Before I close the issue, please submit another patch with these constants in (or provide some explanation why it only adds unnecessary burden ;))

> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
>          Key: GERONIMO-1754
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1754
>      Project: Geronimo
>         Type: New Feature
>   Components: mail
>     Versions: 1.2
>     Reporter: Rick McGuire
>  Attachments: GERONIMO-1754.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira