geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul McMahan" <>
Subject Re: [jira] Updated: (GERONIMO-1783) Welcome application i18n
Date Thu, 30 Mar 2006 17:21:30 GMT
Hello, I applied your patch and could successfully view the welcome
page in spanish.  Nice work! My comments inline.

On 3/30/06, Sean McCarthy <> wrote:
> Hi,
> We would like that someone have a look at it before we start to work on
> the console.
> The new patch is using the JSTL taglib instead of the i18n-taglib. Also
> we are looking at the commons-i18n for the portlet side. The translation
> has been on the source from the trunk version.

I noticed that your patch uses version 1.1.2 of JSTL, whereas the
console currently uses version 1.1.1.  Since the jars add up to about
400k it would be nice to have a shared version of them in the geronimo
repository instead of copies in each webapp.  By the way, upgrading
the console's version to 1.1.2 sounds like a good idea, in fact its
being tracked on the geronimo wiki as a future release candidate.

> Also we are interested to know if there's a chance for the translation
> package (once debugged, reviewed, etc) to be merged with the trunk of
> Geronimo.

I'm not a geronimo committer but I can say that there has been some
discussion a few months ago about the need for internationalization. 
So I think that its very likely your contribution will be merged. 
Mostly depends on when a commiter has some spare cycles.  I will be
happy to help debug, review, and provide assistance with your efforts.
 As a start I suggest opening a JIRA for console i18n in the same way
you did for the welcome app.

> If so we would like to know which packages are the most stable to start
>   translating them.

Based on what's currently under most active development I suggest
going in roughly the following order.  Also, for each of these
packages I recommend following the convention of placing the bundles
in a "resources" subpackage.

-------------- least active
-------------- most active

Please let me know if/how I can help any further.

Best wishes,

> Thanks,
>         Sean
> Sean C. McCarthy (JIRA) wrote:
> >      [ ]
> >
> > Sean C. McCarthy updated GERONIMO-1783:
> > ---------------------------------------
> >
> >     Attachment: welcome.diff
> >
> > New patch using the JSTL taglibs from Jakarta instead taglibs-i18n. The previous
patch didn't work.
> >
> >> Welcome application i18n
> >> ------------------------
> >>
> >>          Key: GERONIMO-1783
> >>          URL:
> >>      Project: Geronimo
> >>         Type: New Feature
> >>     Reporter: Yeray Cabrera Santana
> >>     Priority: Minor
> >>  Attachments: patch.txt, welcome.diff
> >>
> >> Patch for Welcome app includes i18n and Spanish translation. This patch depends
on taglibs-i18n-1.0.jar which is not available on any maven repo.
> >
> --
>     Sean C. McCarthy
>     Integra Soluciones Avanzadas, S.L.
>     Tlf: +34928465203
>     C/ Juan Domínguez Pérez 28, Urb El Sebadal
>     Las Palmas de Gran Canaria (35008)
>     SPAIN

View raw message