geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Wilkins (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-1686) Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
Date Tue, 14 Mar 2006 21:09:45 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-1686?page=comments#action_12370415 ] 

Greg Wilkins commented on GERONIMO-1686:
----------------------------------------


I've done some comparisons of the javax.servlet classes from geronimo to those in jetty6.
The Jetty 6 classes are the apache 1.1 licensed ones from an early version of glassfish to
which I have manually applied the subsequent changes.

As there are many many differences (not least the order of messages), I have
stripped comments from my  diffs. However, many of the changes in the 2.5 spec have been in
the javadoc.

Differences that I have spotted so far are:

* Geronimo classes do not use resource bundles for messages.

* GenericServlet calls super() when it does not need to.

* In GenericServlet, the initParameter, getServletContext and getServletName 
methods are now all protected with an IllegalStateException if the ServletConfig is null (ie
if init(ServletConfig) has been overriden and does not call super).   
This is mandated by the spec now.

* Cookie in geronimo does not default maxAge to -1

* Cookie.clone() in geronimo does not call super.clone()... which I think is bad???

* geronimo is using @override and @deprecated  which I think is needless java5 featurism (I
know java5 is required for compliance.... but there is nothing in the rest of the javax classes
that needs it).












> Servlet 2.5 and JSP 2.1 api jars for JavaEE 5 work
> --------------------------------------------------
>
>          Key: GERONIMO-1686
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1686
>      Project: Geronimo
>         Type: New Feature
>     Reporter: Bill Dudney
>     Assignee: Jeff Genender
>     Priority: Minor
>  Attachments: jee5_exp.patch, jee5_exp_servlet.patch
>
> I'm typing in the Servlet 2.5 and JSP 2.1 api's and will post a patch the week of 3/6/06.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message