Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Mime-Version: 1.0 (Apple Message framework v746.2)
In-Reply-To: <1b5bfeb50602270715v1906eaa7q@mail.gmail.com>
References: <1FDibG-1IoS8m0@fwd31.aul.t-online.de>
 <1b5bfeb50602270715v1906eaa7q@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <AABAA392-9BFF-47BC-9BF3-B2547ACCBCAD@iq80.com>
Content-Transfer-Encoding: 7bit
From: Dain Sundstrom <dain@iq80.com>
Subject: Console patches [was: GERONIMO-1529, GERONIMO-1484,
 or how to get things included]
Date: Mon, 27 Feb 2006 08:47:58 -0800
To: dev@geronimo.apache.org


On Feb 27, 2006, at 7:15 AM, Jacek Laskowski wrote:

> 2006/2/27, schmidtm@mock-software.de <schmidtm@mock-software.de>:
>
>> I've created these two items in January:
>
> Hi,
>
> Not that long ago ;)
>
>> GERONIMO-1529    Console should display Geronimo Version
>> GERONIMO-1484    Display username who is logged into the Webconsole

I'm not a console guy, but I think this info be on the footer of  
every page like JIRA does

>> now i have a couple of questions around how to get things included  
>> since
>> not much happened with them since then:
>
> Perhaps people were busy doing other stuff and missed that one. Not
> that it changes much, but worth to take it into account.
>
>> a) I've provided a fix in the body of the RFE, would it had been  
>> better
>> to attach it as a patch?
>
> A patch is the best way to submit changes since it's just a matter of
> review and commit.

The best way is to "attach" a patch file generated with svn diff.

>> b) Can I assign an item to myself?
>
> Yes.

Once you have earned a bit of karma in the community, we can give you  
rights to assign JIRA issues to yourself.

>> c) what did i done wrong?
>
> Well, submit the updated patch again and I'm sure it will be processed
> very quickly afterwards. I'll keep an eye on it ;)

Looks good to me.

-dain