Return-Path: 
 <dev-return-25848-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 83808 invoked from network); 25 Feb 2006 20:06:52 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 25 Feb 2006 20:06:52 -0000
Received: (qmail 67988 invoked by uid 500); 25 Feb 2006 20:06:51 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 67288 invoked by uid 500); 25 Feb 2006 20:06:49 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 67277 invoked by uid 99); 25 Feb 2006 20:06:49 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 Feb 2006 12:06:49 -0800
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: domain of ammulder@gmail.com designates
 66.249.92.204 as permitted sender)
Received: from [66.249.92.204] (HELO uproxy.gmail.com) (66.249.92.204)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 Feb 2006 12:06:48 -0800
Received: by uproxy.gmail.com with SMTP id k3so231838ugf
        for <dev@geronimo.apache.org>; Sat, 25 Feb 2006 12:06:27 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=k4kP6w1Vfv3poPfm2JglIZz4zZit110urk8FDNTyPaVJjmx1f7Ns+NXQCAY1bcmjtbk08ASlqQSyIefZQKDTD3B9g0nmSYa/X3TccMqoq9aVwdLEL5LHE2Gxd9ySO1se8rNdymvWHn1bNIZ3ufRgVwVQNjz+6tU3FCCJrIit6Do=
Received: by 10.66.184.5 with SMTP id h5mr5006500ugf;
        Sat, 25 Feb 2006 12:06:27 -0800 (PST)
Received: by 10.67.15.17 with HTTP; Sat, 25 Feb 2006 12:06:27 -0800 (PST)
Message-ID: <74e15baa0602251206k51857664y67dd148e68eaccbc@mail.gmail.com>
Date: Sat, 25 Feb 2006 15:06:27 -0500
From: "Aaron Mulder" <ammulder@alumni.princeton.edu>
Sender: ammulder@gmail.com
To: dev@geronimo.apache.org
Subject: Re: Removing attributes and refs from the config.xml
In-Reply-To: <43FFA0F0.9000403@apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <43FEC91B.6020600@apache.org>
	 <74e15baa0602241456r156ed67enb7e326c139736f83@mail.gmail.com>
	 <43FFA0F0.9000403@apache.org>
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

I accidentally followed up to this off-list, but I think Jeff and I
have agreed to disagree.  I prefer to avoid adding extra attributes to
support an empty string value when we don't seem to really have a need
for empty string values.  Jeff (if I can try to summarize) feels that
we ought to support all 3 possibilities (null, empty, not set) for the
benefit of future GBean implementers who might have different needs.=20
Additional input would be appreciated.

Thanks,
   Aaron

On 2/24/06, Jeff Genender <jgenender@apache.org> wrote:
>
>
> Aaron Mulder wrote:
> > What's wrong with just listing the attribute or reference with no
> > content but without the new "empty=3Dtrue"?  As in:
> >
> > <gbean name=3D"TomcatEngine">
> >   <reference name=3D"TomcatValveChain" />
> > </gbean>
> >
>
> This may be fine for references, but an empty string could be a
> reasonable and valid setting for an attribute.  Therefore we need a way
> to designate a difference between an empty string value, a null value,
> and full removal of setting the value.
>
> I also believe that we should be consistent.  So the way we do it for
> one, we probably should do it for the other.
>
> Jeff
>
> > Thanks,
> >     Aaron
> >
> > On 2/24/06, Jeff Genender <jgenender@apache.org> wrote:
> >> The config.xml allows us to declare new GBeans and override references
> >> and attributes of already existing Gbeans. But there is a missing
> >> configuration item here, which is the ability to *remove* a reference =
or
> >> attribute value from the configuration.  Currently there is no way to =
do
> >> this.
> >>
> >> Matt Hogstrom and I ran into this when trying to remove a logging
> >> reference in one of the GBeans.
> >>
> >> An example of this is the TomcatValveChain on the TomcatEngine.  As it
> >> stands, our default implementation installs an AccessLogValve into the
> >> TomcatValveChain reference.  We wanted to shut off logging to test
> >> different performance numbers and found that there was no way to "clea=
r"
> >> or remove a reference that was set in the car plan via the config.xml,
> >> without rebuilding the car from the source.
> >>
> >> On further discussion with David J and Dain, we came up with a new xml
> >> attribute to place on refs and attribute tags. You would use:
> >>
> >> empty=3D"true"
> >>
> >> Example:  You want to remove the access logger to improve web containe=
r
> >> performance, you would declare the following in the config.xml, which
> >> would remove the TomcatValveChain from the TomcatEngine:
> >>
> >> ...
> >> <configuration name=3D"geronimo/tomcat/1.1-SNAPSHOT/car">
> >>     ...
> >>     <gbean name=3D"FirstValve" load=3D"false"/>
> >>
> >>     <gbean name=3D"TomcatEngine">
> >>         <reference name=3D"TomcatValveChain" empty=3D"true"/>
> >>     </gbean>
> >>     ...
> >> </configuration>
> >> ...
> >>
> >> You would do the same for attributes that needed to be removed.
> >>
> >> I have this all coded up and ready to check in, but wanted to get any
> >> feedback or issues before I went ahead and did it.
> >>
> >> Comments?
> >>
> >> Jeff
> >>
>