geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bohn <joe.b...@earthlink.net>
Subject Re: [jira] Commented: (GERONIMO-1648) Eliminate unnecessary config parent (import) dependencies
Date Thu, 23 Feb 2006 22:28:36 GMT

Ok, for openejb it sounds like there are still some misplaced imports so 
this exercise wasn't a wasted effort.  I tried to remove the import for 
axis but I'm hitting some problems with openejb-deploy.

Regarding the daytrader imports:  Can you explain you comment about ease 
to switch databases a bit more?  We would have to provide another 
configuration for another database and it would call out the appropriate 
imports as it requires - no?  Or is your point that we should clearly 
call out all necessary imports/dependencies for each component without 
regard for transitive imports/dependencies so that changes in one 
configuration cannot break another?

Joe


David Jencks (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/GERONIMO-1648?page=comments#action_12367475
] 
> 
> David Jencks commented on GERONIMO-1648:
> ----------------------------------------
> 
> I think most of this is the wrong approach: comments:
> 
> openejb import for j2ee-server - Openejb already has an import of axis which imports
j2ee-server
> 
> It is a really major problem that openejb is importing axis.  I believe this needs to
be solved before we can think about working with axis2.  openejb should be importing j2ee-server
and NOT axis.
> 
> daytrader-jetty import for j2ee-server - daytrader already has an import for system-database
which imports j2ee-server
> I don't thinks system-database needs to import j2ee-server.  I would hope something like
rmi-naming would be sufficient.  Even if this is impossible for some reason I would prefer
to include j2ee-server anyway to make it easier to switch databases.
> 
> daytrader-tomcat import for j2ee-server - daytrader already has an import for system-database
which imports j2ee-server
> ditto.
> 
> 
> One other questionable import is in ldap-demo-jetty which imports ldap-realm. I wonder
about this one because ldap-demo-tomcat doesn't include the same import. It seems like either
both should need this or neither one would need it.
> 
> If it works without the import, let's leave it out.  When the configid stuff is further
along we can include a service-only dependency that will assure the ldap-realm has started
but won't include anything in the classpath
> 
> 
> 
>>Eliminate unnecessary config parent (import) dependencies
>>---------------------------------------------------------
>>
>>         Key: GERONIMO-1648
>>         URL: http://issues.apache.org/jira/browse/GERONIMO-1648
>>     Project: Geronimo
>>        Type: Improvement
>>  Components: general
>>    Versions: 1.1
>> Environment: win-xp
>>    Reporter: Joe Bohn
>>    Priority: Minor
>>     Fix For: 1.1
>> Attachments: DuplicateImports.patch
>>
>>There are several parent dependencies that appear to be redunant in the configurations.
 They include:
>>openejb import for j2ee-server  -  Openejb already has an import of axis which imports
j2ee-server
>>daytrader-jetty import for j2ee-server - daytrader already has an import for system-database
which imports j2ee-server
>>daytrader-tomcat import for j2ee-server - daytrader already has an import for system-database
which imports j2ee-server
>>One other questionable import is in ldap-demo-jetty which imports ldap-realm.   I
wonder about this one because ldap-demo-tomcat doesn't include the same import.  It seems
like either both should need this or neither one would need it.
> 
> 

-- 
Joe Bohn
joe.bohn at earthlink.net

"He is no fool who gives what he cannot keep, to gain what he cannot 
lose."   -- Jim Elliot

Mime
View raw message