geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Sisson <jrsis...@gmail.com>
Subject Re: svn commit: r373796 - in /geronimo/branches/1.0: assemblies/j2ee-installer/project.xml configs/console-tomcat/project.xml
Date Wed, 01 Feb 2006 02:29:16 GMT
Probably best at this stage being so close to 1.0.1 to back out my 
change and get this fixed in head for 1.1

Thanks,

John

David Jencks wrote:
>
> On Jan 31, 2006, at 6:12 PM, John Sisson wrote:
>
>> Good catch!  Regarding GERONIMO-1441, are you happy with me changing 
>> the assembly plugin and the three assembly project.xml files in the 
>> 1.0 branch & trunk to use specific property names and remove support 
>> for the old form, or would you prefer we support both forms of 
>> properties in the assembly plugin?
>
> I think a single notation will be less confusing.  I don't think we 
> need to support the old form.  We use the assembly plugin in the tck 
> setup as well.  Are you sure we have time to do this reliably for 
> 1.0.1?  Will this have an impact on the installer?
>
> thanks
> david jencks
>
>>
>> E.G. in the assembly project.xml files, change all:
>>
>> <geronimo.assemble>endorsed</geronimo.assemble>
>> to:
>> <geronimo.assemble.endorsed>true</geronimo.assemble.endorsed>
>>
>> <geronimo.assemble>library</geronimo.assemble>
>> to:
>> <geronimo.assemble.library>true</geronimo.assemble.library>
>>
>> <geronimo.assemble>repository</geronimo.assemble>
>> to:
>> <geronimo.assemble.repository>true</geronimo.assemble.repository>
>>
>> <geronimo.assemble>extension</geronimo.assemble>
>> to:
>> <geronimo.assemble.extension>true</geronimo.assemble.extension>
>>
>> Thanks,
>>
>> John
>>
>> David Jencks wrote:
>>> There's a problem with part of this:
>>>
>>>
>>> On Jan 31, 2006, at 3:37 AM, jsisson@apache.org wrote:
>>>
>>>> Author: jsisson
>>>> Date: Tue Jan 31 03:36:47 2006
>>>> New Revision: 373796
>>>>
>>>> URL: http://svn.apache.org/viewcvs?rev=373796&view=rev
>>>> Log:
>>>> GERONIMO-1441 - comment out, consolidate or remove duplicate 
>>>> dependencies that cause "Build path contains duplicate entry" 
>>>> errors in eclipse 3.1.1 projects.
>>>>
>>>>
>>>
>>> <snip>
>>>>          <dependency>
>>>>              <groupId>geronimo</groupId>
>>>> @@ -550,6 +551,7 @@
>>>>              <version>${geronimo_spec_qname_version}</version>
>>>>              <properties>
>>>>                  <geronimo.assemble>library</geronimo.assemble>
>>>> +                <geronimo.assemble>repository</geronimo.assemble>
>>>>              </properties>
>>>>          </dependency>
>>>
>>> having two properties with the same name doesn't work.  The 
>>> dependency ends up in either the library or the repository but not 
>>> both.
>>>
>>> I just fixed a bunch of these in GERONIMO-1541
>>>
>>> I think we need each target dir to have a separate name, e.g. 
>>> <geronimo.assemble.library>true</geronimo.assemble.library>
>>>
>>> thanks
>>> david jencks
>>>
>>>
>>
>
>


Mime
View raw message