Return-Path: 
 <dev-return-22479-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 25083 invoked from network); 22 Dec 2005 02:21:57 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 22 Dec 2005 02:21:57 -0000
Received: (qmail 22221 invoked by uid 500); 22 Dec 2005 02:21:54 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 21961 invoked by uid 500); 22 Dec 2005 02:21:52 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 21947 invoked by uid 99); 22 Dec 2005 02:21:52 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Dec 2005 18:21:52 -0800
Received: from ajax.apache.org (ajax.apache.org [127.0.0.1])
	by ajax.apache.org (Postfix) with ESMTP id 0B94DCB
	for <dev@geronimo.apache.org>; Thu, 22 Dec 2005 03:21:31 +0100 (CET)
Message-ID: <83333648.1135218091046.JavaMail.jira@ajax.apache.org>
Date: Thu, 22 Dec 2005 03:21:31 +0100 (CET)
From: "Sachin Patel (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMODEVTOOLS-26) Eclipse plugin build will
 always miss geronimo-jetty-j2ee-*.zip in the local maven repo
In-Reply-To: <58637463.1135216710504.JavaMail.jira@ajax.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

    [ http://issues.apache.org/jira/browse/GERONIMODEVTOOLS-26?page=comments#action_12361088 ] 

Sachin Patel commented on GERONIMODEVTOOLS-26:
----------------------------------------------

This is incorrect.  The current syntax is correct as is. If the zip is not available in the local repo, it will pull it down from cvs.apache.org

> Eclipse plugin build will always miss geronimo-jetty-j2ee-*.zip in the local maven repo
> ---------------------------------------------------------------------------------------
>
>          Key: GERONIMODEVTOOLS-26
>          URL: http://issues.apache.org/jira/browse/GERONIMODEVTOOLS-26
>      Project: Geronimo-Devtools
>         Type: Bug
>   Components: eclipse-plugin
>  Environment: Discovered on Windows. Probably affects build on all operating systems.
>     Reporter: Bill Stoddard
>     Priority: Minor

>
> Correct the file available test to enable the build to discover the file in the local maven repository.
> C:\home\apache\devtools\modules\eclipse-plugin\plugins>svn diff
> svn diff
> Index: org.apache.geronimo.j2ee.server.v1/maven.xml
> ===================================================================
> --- org.apache.geronimo.j2ee.server.v1/maven.xml	(revision 358391)
> +++ org.apache.geronimo.j2ee.server.v1/maven.xml	(working copy)
> @@ -28,7 +28,7 @@
>    <goal name="getzip">
>      <ant:property name="geronimo.zip" value="geronimo-jetty-j2ee-${geronimo.version}.zip"/>
>      <ant:available file="${maven.repo.local}/geronimo/distributions/${geronimo.zip}" property="zip.present"/>
> -    <j:if test="${zip.present != 'true'}">
> +    <j:if test="${zip.present} != 'true'">
>           <ant:mkdir dir="${maven.repo.local}/geronimo/distributions/"/>
>           <ant:get src="http://cvs.apache.org/repository/geronimo/distributions/${geronimo.zip}" dest="${maven.repo.local}/geronimo/distributions/${geronimo.zip}"/>
>      </j:if>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira