Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (asf.osuosl.org: domain of ammulder@gmail.com designates
 64.233.162.192 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=GsFJcTvdKaCEAFIuRh3OyDVE9MbgePLeBXPl7zdMP1koiXGltG3xB9xV9bV6EaL5d+YS1q3za+2aEK0c8itb3C/WHgd4gT2oczL9YAGkKuUbJg95DZ7bz+rze26dibXygDQy6X43Jgo+7QH3X2ZdjidL1+VhSZ4Z6JHHMmOSQHo=
Message-ID: <74e15baa0512191111ka1eec33gcbf372cfe34c6b43@mail.gmail.com>
Date: Mon, 19 Dec 2005 14:11:12 -0500
From: Aaron Mulder <ammulder@alumni.princeton.edu>
Sender: ammulder@gmail.com
To: dev@geronimo.apache.org
Subject: Re: svn commit: r357646 -
 /geronimo/branches/1.0/modules/jetty-builder/src/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilder.java
In-Reply-To: <4BED4372-F981-46FB-81A8-9DE35989F0A7@yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <20051219055749.34712.qmail@minotaur.apache.org>
	 <4BED4372-F981-46FB-81A8-9DE35989F0A7@yahoo.com>

OK, can we just drop the test for isSetSecurity for now?  It looks
like if a realm is set but no security configuration was provided this
will be caught on line 809.

Thanks for catching this!

Aaron

On 12/19/05, David Jencks <david_jencks@yahoo.com> wrote:
> Unfortunately this code is wrong.  The test for
> gerWebApp.isSetSecurityRealmName()  is correct but the test for
> gerWebApp.isSetSecurity() is not.  The role-principal mapping can be
> set anywhere in the geronimo plan, not just in the web plan.  The
> processed mapping info is stored in the EarContext and will be
> available in a later step in deployment.
>
> Unfortunately I don't have a development environment set up yet so am
> having some difficulty in supplying more info or repairing the problem.
>
> thanks
> david jencks
>
> On Dec 18, 2005, at 9:57 PM, hogstrom@apache.org wrote:
>
> > Author: hogstrom
> > Date: Sun Dec 18 21:57:46 2005
> > New Revision: 357646
> >
> > URL: http://svn.apache.org/viewcvs?rev=3D357646&view=3Drev
> > Log:
> > GERONIMO-1384 Fixed secure pages issue in 1.0
> >
> > Modified:
> >     geronimo/branches/1.0/modules/jetty-builder/src/java/org/apache/
> > geronimo/jetty/deployment/JettyModuleBuilder.java
> >
> > Modified: geronimo/branches/1.0/modules/jetty-builder/src/java/org/
> > apache/geronimo/jetty/deployment/JettyModuleBuilder.java
> > URL: http://svn.apache.org/viewcvs/geronimo/branches/1.0/modules/
> > jetty-builder/src/java/org/apache/geronimo/jetty/deployment/
> > JettyModuleBuilder.java?rev=3D357646&r1=3D357645&r2=3D357646&view=3Ddif=
f
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > =3D=3D=3D=3D=3D=3D=3D=3D
> > --- geronimo/branches/1.0/modules/jetty-builder/src/java/org/apache/
> > geronimo/jetty/deployment/JettyModuleBuilder.java (original)
> > +++ geronimo/branches/1.0/modules/jetty-builder/src/java/org/apache/
> > geronimo/jetty/deployment/JettyModuleBuilder.java Sun Dec 18
> > 21:57:46 2005
> > @@ -421,6 +421,10 @@
> >          GerMessageDestinationType[] gerMessageDestinations =3D
> > gerWebApp.getMessageDestinationArray();
> >
> >          ENCConfigBuilder.registerMessageDestinations
> > (earContext.getRefContext(), module.getName(), messageDestinations,
> > gerMessageDestinations);
> > +        if((webApp.getSecurityConstraintArray().length > 0 ||
> > webApp.getSecurityRoleArray().length > 0) &&
> > +                (!gerWebApp.isSetSecurityRealmName() || !
> > gerWebApp.isSetSecurity())) {
> > +            throw new DeploymentException("web.xml includes
> > security elements but Geronimo deployment plan is not provided or
> > does not contain <security-realm-name> and <security> elements
> > necessary to configured security accordingly.");
> > +        }
> >          if (gerWebApp.isSetSecurity()) {
> >              if (!gerWebApp.isSetSecurityRealmName()) {
> >                  throw new DeploymentException("You have supplied a
> > security configuration for web app " + module.getName() + " but no
> > security-realm-name to allow login");
> >
> >
>
>