Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <40461883.1135185335943.JavaMail.jira@ajax.apache.org>
Date: Wed, 21 Dec 2005 18:15:35 +0100 (CET)
From: "Joe Bohn (JIRA)" <dev@geronimo.apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Updated: (GERONIMO-1336) Setting the Max PoolSize on a
 DataBase pool with invalid information does not yield an error message and
 silently fails
In-Reply-To: <696531146.1134337508486.JavaMail.jira@ajax.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/GERONIMO-1336?page=all ]

Joe Bohn updated GERONIMO-1336:
-------------------------------

    Attachment: DBPoolValidate.patch

Updated the JSP to validate that the min pool is >= 0 and the max pool is > 0 prior to submit. 
This patch was created from the root Geronimo directory.

> Setting the Max PoolSize on a DataBase pool with invalid information does not yield an error message and silently fails
> -----------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1336
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1336
>      Project: Geronimo
>         Type: Bug
>   Components: console
>     Versions: 1.0-M5
>     Reporter: Matt Hogstrom
>     Assignee: Joe Bohn
>      Fix For: 1.1
>  Attachments: DBPoolValidate.patch
>
> When attempting a set of the SystemDatabase pool to a negative value the save command executes and gives the appearance that the change was made.  At least there is no information that indicates it failed.  The following error is logged in the geronimo.log.  The Console should detect this error and inform the user that an invalid value was specified.
> 13:38:37,813 ERROR [DatabasePoolPortlet] Unable to save connection pool
> java.lang.IllegalArgumentException: Max size must be positive, not -1
>         at org.apache.geronimo.connector.outbound.AbstractSinglePoolConnectionInterceptor.setPartitionMaxSize(AbstractSinglePoolConnectionInterceptor.java:149)
>         at org.apache.geronimo.connector.outbound.connectionmanagerconfig.SinglePool.setPartitionMaxSize(SinglePool.java:143)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager.setPartitionMaxSize(AbstractConnectionManager.java:104)
>         at org.apache.geronimo.connector.outbound.AbstractConnectionManager$$FastClassByCGLIB$$80012030.invoke(<generated>)
>         at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
>         at org.apache.geronimo.gbean.runtime.FastMethodInvoker.invoke(FastMethodInvoker.java:38)
>         at org.apache.geronimo.gbean.runtime.GBeanAttribute.setValue(GBeanAttribute.java:403)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:698)
>         at org.apache.geronimo.gbean.runtime.GBeanInstance.setAttribute(GBeanInstance.java:683)
>         at org.apache.geronimo.gbean.runtime.RawInvoker.setAttribute(RawInvoker.java:53)
>         at org.apache.geronimo.kernel.basic.RawSetAttributeInvoker.invoke(RawSetAttributeInvoker.java:36)
>         at org.apache.geronimo.kernel.basic.ProxyMethodInterceptor.intercept(ProxyMethodInterceptor.java:96)
>         at org.apache.geronimo.connector.outbound.ConnectionManagerContainer$$EnhancerByCGLIB$$813b4258.setPartitionMaxSize(<generated>)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.save(DatabasePoolPortlet.java:940)
>         at org.apache.geronimo.console.databasemanager.wizard.DatabasePoolPortlet.processAction(DatabasePoolPortlet.java:337)
>         at org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:229)
>         at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira