Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=Received:Mime-Version:In-Reply-To:References:Content-Type:Message-Id:Content-Transfer-Encoding:From:Subject:Date:To:X-Mailer;
  b=OvT4GW8VkWUGyVP84KbEMf5i/NiYYfCNdoY+vXJ7akUNPRdjJK+vqSi0eCgzMZYWMAfp2Mj3Yg8m3lNp0yVskeimlHAzUm++OH4VlVvrCgNAzRQDNWqvJzcX1rgEmhmntIDjwX1G/xsBaSCO4ydTLeu1ObE+QzTrn17M0trtNuc=
  ;
Mime-Version: 1.0 (Apple Message framework v622)
In-Reply-To: <438DA193.5090102@gmail.com>
References: <438DA193.5090102@gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <4f40dd9c88a5c66d1e4ace67f81d2152@yahoo.com>
Content-Transfer-Encoding: 7bit
From: David Jencks <david_jencks@yahoo.com>
Subject: Re: Daemon.doStartup() code does not call loadFailed and startFailed
 methods of the StartupMonitor interface
Date: Wed, 30 Nov 2005 08:27:07 -0800
To: dev@geronimo.apache.org


On Nov 30, 2005, at 4:56 AM, John Sisson wrote:

> This one is probably for Aaron..
>
> I am looking at the Daemon.doStartup() code and noticed that it 
> doesn't call the loadFailed and startFailed methods of the 
> StartupMonitor interface (used by the ProgressBarStartupMonitor and 
> the StaticStartupMonitor I am working on).
>
> Currently the doStartup() code calls loadGBeans() and start(), and 
> they can throw InvalidConfigException. If that happens, the server is 
> shut down.
>
> Should we try to limp on if that happens and pass the exception to the 
> loadFailed or startFailed methods of the StartupMonitor interface or 
> is there a good reason why we shut down the server under these 
> circumstances?

I think shutting down is the most appropriate action at that point.

thanks
david jencks
>
> John
>