Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 23415 invoked from network); 30 Nov 2005 12:57:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 30 Nov 2005 12:57:24 -0000 Received: (qmail 38086 invoked by uid 500); 30 Nov 2005 12:57:20 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 38037 invoked by uid 500); 30 Nov 2005 12:57:19 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 38026 invoked by uid 99); 30 Nov 2005 12:57:19 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2005 04:57:19 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of jrsisson@gmail.com designates 64.233.162.203 as permitted sender) Received: from [64.233.162.203] (HELO zproxy.gmail.com) (64.233.162.203) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2005 04:58:49 -0800 Received: by zproxy.gmail.com with SMTP id 9so1713193nzo for ; Wed, 30 Nov 2005 04:56:56 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:x-accept-language:mime-version:to:subject:content-type:content-transfer-encoding; b=VF+ljSmegHx2yE1+jhflbISiFtRaowAm1wDchvSKut017IK+KSpOdTiLJzMmkm1I+Fw/2wR53O/+Tw5qTEo7OT8BBH8ZayXbFZwtmQPG8DZ777fxOekIC5JF9VbCH23IAX61hRmTSWtsjIHkiMQueTCFNRa3rcV7fp2te+rQC5k= Received: by 10.36.50.19 with SMTP id x19mr169378nzx; Wed, 30 Nov 2005 04:56:55 -0800 (PST) Received: from ?192.168.0.21? ( [59.167.21.209]) by mx.gmail.com with ESMTP id i5sm1461211nzi.2005.11.30.04.56.54; Wed, 30 Nov 2005 04:56:55 -0800 (PST) Message-ID: <438DA193.5090102@gmail.com> Date: Wed, 30 Nov 2005 23:56:51 +1100 From: John Sisson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@geronimo.apache.org Subject: Daemon.doStartup() code does not call loadFailed and startFailed methods of the StartupMonitor interface Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N This one is probably for Aaron.. I am looking at the Daemon.doStartup() code and noticed that it doesn't call the loadFailed and startFailed methods of the StartupMonitor interface (used by the ProgressBarStartupMonitor and the StaticStartupMonitor I am working on). Currently the doStartup() code calls loadGBeans() and start(), and they can throw InvalidConfigException. If that happens, the server is shut down. Should we try to limp on if that happens and pass the exception to the loadFailed or startFailed methods of the StartupMonitor interface or is there a good reason why we shut down the server under these circumstances? John