Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 2958 invoked from network); 23 Nov 2005 08:17:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 23 Nov 2005 08:17:04 -0000 Received: (qmail 73172 invoked by uid 500); 23 Nov 2005 08:16:59 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 73128 invoked by uid 500); 23 Nov 2005 08:16:59 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 73117 invoked by uid 99); 23 Nov 2005 08:16:59 -0000 X-ASF-Spam-Status: No, hits=1.3 required=10.0 tests=SPF_FAIL X-Spam-Check-By: apache.org Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Nov 2005 00:16:57 -0800 Received: from ajax.apache.org (ajax.apache.org [127.0.0.1]) by ajax.apache.org (Postfix) with ESMTP id E4D13592 for ; Wed, 23 Nov 2005 09:16:36 +0100 (CET) Message-ID: <357751917.1132733796934.JavaMail.jira@ajax.apache.org> Date: Wed, 23 Nov 2005 09:16:36 +0100 (CET) From: "Gao Yong Pan (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Updated: (GERONIMO-1223) Hot Deploy performance improvement Just check directories -patch available In-Reply-To: <141254523.1132732776261.JavaMail.jira@ajax.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/GERONIMO-1223?page=all ] Gao Yong Pan updated GERONIMO-1223: ----------------------------------- Attachment: DirectoryMonitor.java.patch > Hot Deploy performance improvement Just check directories -patch available > -------------------------------------------------------------------------- > > Key: GERONIMO-1223 > URL: http://issues.apache.org/jira/browse/GERONIMO-1223 > Project: Geronimo > Type: Improvement > Components: deployment > Versions: 1.0 > Environment: linux or windows > Reporter: Gao Yong Pan > Attachments: DirectoryMonitor.java.patch > > The method getLastModifiedInDir in the hot-deploy/src/java/org/apache/geronimo/deployment/hot/DirectoryMonitor.java is using the algorithm by calculating highest modified time of any files or directories, this could be improved. > In fact, we only need to check every directory is enough, because any changes, for example, add, remove, edit any files in a directory, the change can be reflected by its parent directory's modification time, so we don't need to check files. > I also write a patch for the issue. A simple performance testing shows that the patch will improve 58% of the performance. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira