geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Mulder <ammul...@alumni.princeton.edu>
Subject Re: backward m5 deployment capability broken
Date Tue, 29 Nov 2005 18:25:20 GMT
Yeah, it wouldn't bother me if we don't support using 1.0 JARs to deploy to M5.

Aaron

On 11/29/05, David Jencks <david_jencks@yahoo.com> wrote:
> Please add comments that the URI branch is 1.0 and ObjectName is M5.
>
> There were a lot of places I had to change for this, and I won't
> attempt to guess if there will be other problems.  I'm not convinced
> that attempting to support both M5 and 1.0 here is viable.
>
> thanks
> david jencks
>
> On Nov 29, 2005, at 8:26 AM, Sachin Patel wrote:
>
> > That'll work.  RedeployCommand will need the same fix as well. Any
> > objections with me going ahead with the fix?  Would fixing it only in
> > the deploy-jsr88 cause problems anywhere else loadRecusrsive() is
> > used?
> >
> > Sachin
> >
> > Dain Sundstrom wrote:
> >> How about we just support both objectNames and URIs:
> >>
> >> for (int j = 0; j < list.size(); j++) {
> >>     Object o = list.get(j);
> >>     URI name;
> >>     if (o instanceof ObjectName) {
> >>         ObjectName objectName = (ObjectName) o;
> >>         String uriString = objectName.getKeyProperty("name");
> >>         uriString = ObjectName.unquote(uriString);
> >>         name = new URI(uriString);
> >>     } else  {
> >>         name = (URI) o;
> >>     }
> >>
> >> If we go this route, I suggest we put the middle part into a static
> >> method in Configuration:
> >>
> >> public static URI getConfigurationId(ObjectName objectName) throws
> >> URISyntaxException {
> >>     String uriString = objectName.getKeyProperty("name");
> >>     uriString = ObjectName.unquote(uriString);
> >>     URI id = new URI(uriString);
> >>     return id;
> >> }
> >>
> >>
> >> -dain
> >>
> >> On Nov 29, 2005, at 7:45 AM, Sachin Patel wrote:
> >>
> >>> The deployment capability using the 1.0 snapshot deployment jars to
> >>> deploy to M5 is broken do to the following change made in
> >>> org.apache.geronimo.deployment.plugin.local.StartCommand
> >>>
> >>> In M5 the list below contained ObjectName entries
> >>>
> >>> // Load and start the module
> >>> List list = configurationManager.loadRecursive(moduleID);
> >>> for (int j = 0; j < list.size(); j++) {
> >>>   ObjectName name = (ObjectName) list.get(j);
> >>> ...
> >>>
> >>> This was changed to use a list of URI's
> >>>
> >>> List list = configurationManager.loadRecursive(moduleID);
> >>> for (int j = 0; j < list.size(); j++) {
> >>>   URI name = (URI) list.get(j);
> >>>
> >>> This of course causing a ClassCastException at the point.
> >>>
> >>> Can we introduce additional code to support backward compatibility
> >>> to M5?  How hard would this be?  I assume there are other areas like
> >>> this that also need to be fixed.  I can help out if needed.
> >>>
> >>> Sachin
> >>
> >>
> >
>
>

Mime
View raw message