geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Hogstrom <m...@hogstrom.org>
Subject Re: [jira] Commented: (GERONIMO-383) xmlbeans magic allows us to accept some invalid deployment descriptors
Date Fri, 11 Nov 2005 15:06:35 GMT
I put this in 1.x as a target.  Does this need to be a 1.0 item?

David Jencks (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/GERONIMO-383?page=comments#action_12357365
] 
> 
> David Jencks commented on GERONIMO-383:
> ---------------------------------------
> 
> yes, this area needs a thorough review to make sure we are validating pre-j2ee 1.4 descriptors
properly before converting them to j2ee 1.4 descriptors.  I believe there are still quite
a few unvalidated cases.
> 
>>xmlbeans magic allows us to accept some invalid deployment descriptors
>>----------------------------------------------------------------------
>>
>>         Key: GERONIMO-383
>>         URL: http://issues.apache.org/jira/browse/GERONIMO-383
>>     Project: Geronimo
>>        Type: Bug
>>  Components: deployment
>>    Versions: 1.0-M2
>>    Reporter: David Jencks
>>    Assignee: David Jencks
>>     Fix For: 1.x
> 
>>The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment
descriptors to 1.4 versions can have the unintended side effect of converting invalid 1.4
descriptors to valid ones.  This has been fixed in SchemaConversionUtils.conv
ertToServletSchema for servlet 1.3 web.xml.  We should apply this same fix of checking for
namespace before conversion to other modules (ejb etc) and extend the checking to:
>>1. look for the DOCTYPE using xmlbeans
>>2. converting to a made-up namespace for that dtd
>>3. validating against xmlbeans objects for the schema corresponding to the dtd.
> 


Mime
View raw message