geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gao Yong Pan (JIRA)" <>
Subject [jira] Commented: (GERONIMO-1223) Hot Deploy performance improvement Just check directories -patch available
Date Fri, 25 Nov 2005 08:25:57 GMT
    [ ] 

Gao Yong Pan commented on GERONIMO-1223:

I found one situation  that the patch won't work.
[pgy@localhost sample]$ cp file2 dir1                                            
[pgy@localhost sample]$ stat -c %y dir1/file2 dir1
2005-11-25 16:29:20.522243936 +0800
2005-11-25 16:28:27.028376240 +0800

Please discard the patch.

> Hot Deploy performance improvement Just check directories -patch available
> --------------------------------------------------------------------------
>          Key: GERONIMO-1223
>          URL:
>      Project: Geronimo
>         Type: Improvement
>   Components: deployment
>     Versions: 1.0
>  Environment: linux or windows
>     Reporter: Gao Yong Pan
>  Attachments:
> The method getLastModifiedInDir in the hot-deploy/src/java/org/apache/geronimo/deployment/hot/
is using the algorithm by calculating highest modified time of any files or directories, this
could be improved.
> In fact, we only need to check every directory is enough, because any changes, for example,
add, remove, edit any files in a directory, the change can be reflected by its current directory's
modification time, so  we don't need to check files.
> I also write a patch for the issue. A simple performance testing shows that the patch
will improve 58% of the performance.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message