Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 15483 invoked from network); 1 Oct 2005 16:36:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Oct 2005 16:36:20 -0000 Received: (qmail 46673 invoked by uid 500); 1 Oct 2005 16:36:16 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 46619 invoked by uid 500); 1 Oct 2005 16:36:15 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 46607 invoked by uid 99); 1 Oct 2005 16:36:14 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Oct 2005 09:36:14 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=RCVD_BY_IP,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of ammulder@gmail.com designates 64.233.162.204 as permitted sender) Received: from [64.233.162.204] (HELO zproxy.gmail.com) (64.233.162.204) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Oct 2005 09:36:18 -0700 Received: by zproxy.gmail.com with SMTP id 9so112297nzo for ; Sat, 01 Oct 2005 09:35:51 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=bzuEmAlOaH6eNp5YOHyegLA80cBUvE5HFq7MIfBevPHawnnAu13Pv47TnektWkYOOyheMDAG5Ip70+O38sZfj6/P7bpV6x6XRZ6Nd+dZ5A4JGoEMQrV6/Wzwv8sRR1Sq89VgSQUapApF6l7tGm0Gq0vsLJwYp9CbeeeRQ9W9p9w= Received: by 10.36.108.12 with SMTP id g12mr2093951nzc; Sat, 01 Oct 2005 09:35:49 -0700 (PDT) Received: by 10.37.13.67 with HTTP; Sat, 1 Oct 2005 09:35:16 -0700 (PDT) Message-ID: <74e15baa0510010935n531ddd00lf35bae21a12cb671@mail.gmail.com> Date: Sat, 1 Oct 2005 12:35:16 -0400 From: Aaron Mulder Reply-To: Aaron Mulder Sender: ammulder@gmail.com To: dev@geronimo.apache.org Subject: Re: [jira] Commented: (GERONIMO-518) Deploying Struts app fails on Logging ClassCastException In-Reply-To: <433EB86D.8020208@savoirtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <640914344.1102300702638.JavaMail.apache@nagoya> <1632517066.1128016727763.JavaMail.jira@ajax.apache.org> <46494.12.17.202.43.1128020660.squirrel@mirage.savoirtech.com> <74e15baa0510010734s7c8898ccx837f872002ebe555@mail.gmail.com> <19f1078d5d0d2a0096307d21aefe18e3@yahoo.com> <433EB86D.8020208@savoirtech.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Jeff, I think I'm OK with your conclusion, but I am not at all in sync with your logic. On 10/1/05, Jeff Genender wrote: > I don't agree with you about not removing the hard coded part. What if > I write my own patches to commons-logging to fix some of these issues > and do my own specialized logging. OK, so lets follow this scenario. You create a custom commons-logging. In order to get your app to use it, you have 2 options: 1) Replace the commons-logging that Geronimo uses (just copy over the file in the repository or whatever). Result: Whatever we do with exclusion lists is irrelevant in this case, since there's only 1 version of commons-logging -- your patched one. Your patched one is used. 2) You add your patched version to WEB-INF/lib so your web app will use it, but Geronimo won't. If we have an exclusion list, you remove commons-logging from it. You set the web app class loading flag to load from the WEB-INF/lib before the parent. Result: You get a ClassCastException because your version in WEB-INF/lib has to touch our global logging instances which implement our commons logging interfaces, not yours. Do you disagree? Aaron