geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dain Sundstrom <>
Subject Re: [jira] Commented: (GERONIMO-1060) Improvements to attribute management
Date Wed, 12 Oct 2005 21:47:13 GMT
On Oct 11, 2005, at 7:40 PM, David Jencks wrote:

> I'd appreciate review of this, mostly the changes to  
> ConfigurationManagerImpl and how it is used to start configurations.

This is going to take me a few days to digest :)  but it looks good.

> Also, looking at the large number of test case modifications, I  
> think we need some kind of test helper module to make starting  
> stuff in a kernel easier.  Dain, would anything in xbean (should we  
> use it) make this unnecessary?

I think too many tests are starting kernels for really no reason.   
Wiring the beans together by hand is good enough for most of them.

As for XBean stuff, we don't have anything to address this, other  
then the kernel does a lot less, so there is a lot less to setup.


View raw message