geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <...@geronimo.apache.org>
Subject [jira] Closed: (GERONIMO-1008) Leading blank lines in <url-pattern>
Date Fri, 28 Oct 2005 19:54:56 GMT
     [ http://issues.apache.org/jira/browse/GERONIMO-1008?page=all ]
     
David Jencks closed GERONIMO-1008:
----------------------------------

    Fix Version: 1.0
     Resolution: Fixed
      Assign To: David Jencks

Added lotsa trim()s to the urlPatterns.  Have not verified that the tck is ok with this.

Sending        modules/jetty-builder/src/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilder.java
Sending        modules/tomcat-builder/src/java/org/apache/geronimo/tomcat/deployment/TomcatModuleBuilder.java
Transmitting file data ..
Committed revision 329279.

> Leading blank lines in <url-pattern>
> ------------------------------------
>
>          Key: GERONIMO-1008
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1008
>      Project: Geronimo
>         Type: Bug
>   Components: web
>     Versions: 1.0-M4
>  Environment: all
>     Reporter: anita kulshreshtha
>     Assignee: David Jencks
>     Priority: Minor
>      Fix For: 1.0

>
>    This issue was discussed in GERONIMO-654. Leading blank lines in the <url-pattern>
element  of the deployment descriptor are not stripped. Hence the deployer gives the following
error :
>  Error: Unable to distribute jsp-examples.war: <url-pattern> must not
>  contain LF(#xA)
> Servlet 2.4 spec, SRV 13.2 says : 
> . Web containers must remove all leading and trailing whitespace, which is defined as
"S(white space)" in XML 1.0 (http://www.w3.org/TR/2000/WD-xml-2e-20000814), for the element
content of the text nodes of a deployment descriptor.
> ...
> ...
> . URI paths specified in the deployment descriptor are assumed to be in URLdecoded form.
The containers must inform the developer with a descriptive error message when URL contains
CR(#xD) or LF(#xA). The containers must preserve all other characters including whitespace
in URL.
>     After talking to Tomcat folks and IMHO we should allow
> <url-pattern>
>            /foo
> </url-pattern>
>         and give error message for :
> <url-pattern>
>           /foo
>           /bar
> </url-pattern>
>    This applies to both web containers.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message