geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anita kulshreshtha <a_kuls...@yahoo.com>
Subject Re: Combine common code in jetty and tomcat module builders?
Date Sat, 29 Oct 2005 12:18:05 GMT
    I do not have a working version :-(. I am still
making changes to 'tomcat' module to avoid using
tomcat's deployer. I will need time to finish this.
But after this the refactoring should be very easy.
Yes! I will do the refactoring after everything starts
working. 

Thanks
Anita  

--- David Jencks <david_jencks@yahoo.com> wrote:

> If you have a working version, please submit it! 
> This is great news!  
> I think I should wait on combining them until your
> code is in.  If you 
> want to do the refactoring that would also be great!
> 
> thanks
> david jencks
> 
> On Oct 28, 2005, at 6:11 AM, anita kulshreshtha
> wrote:
> 
> >   Good idea. As discussed with Jeff offline I have
> > been working on G-1035. I have made changes to the
> > existing TomcatModuleBuilder to make it almost
> > identical to JettyModuleBuilder except for the
> very
> > small container specific part. Please let me know
> if
> > you would like me to submit this at this stage.
> >
> > Thanks
> > Anita
> >
> > --- Jeff Genender <jgenender@apache.org> wrote:
> >
> >> +1...this is very good.
> >>
> >> Jeff
> >>
> >> David Jencks wrote:
> >>> I think there's a lot of code copied from the
> >> jetty to the tomcat module
> >>> builder.  Now that both are somewhere near the
> >> verge of stability, I'd
> >>> like to refactor the common parts into a common
> >> superclass.  Any
> >>> objections?
> >>>
> >>> thanks
> >>> david jencks
> >>
> >> -- 
> >> Jeff Genender
> >> http://geronimo.apache.org
> >>
> >>
> >
> >
> >
> > 		
> > __________________________________
> > Yahoo! FareChase: Search multiple travel sites in
> one click.
> > http://farechase.yahoo.com
> >
> 
> 


	
		
__________________________________ 
Yahoo! Mail - PC Magazine Editors' Choice 2005 
http://mail.yahoo.com

Mime
View raw message