Return-Path: 
 <dev-return-15988-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 65842 invoked from network); 24 Aug 2005 14:15:40 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 24 Aug 2005 14:15:40 -0000
Received: (qmail 84680 invoked by uid 500); 24 Aug 2005 14:15:36 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 84647 invoked by uid 500); 24 Aug 2005 14:15:36 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 84631 invoked by uid 99); 24 Aug 2005 14:15:36 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Aug 2005 07:15:36 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Received: from [66.250.40.202] (HELO saturn.opentools.org) (66.250.40.202)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Aug 2005 07:15:52 -0700
Received: by saturn.opentools.org (Postfix, from userid 500)
	id A46D73FA0; Wed, 24 Aug 2005 10:31:30 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])
	by saturn.opentools.org (Postfix) with ESMTP id 9D5F6F3A9
	for <dev@geronimo.apache.org>; Wed, 24 Aug 2005 10:31:30 -0400 (EDT)
Date: Wed, 24 Aug 2005 10:31:30 -0400 (EDT)
From: Aaron Mulder <ammulder@alumni.princeton.edu>
X-X-Sender: ammulder@saturn.opentools.org
To: dev@geronimo.apache.org
Subject: Re: svn commit: r239527 - in /geronimo/trunk/modules/tomcat-builder:
 project.properties src/schema/geronimo-tomcat.xsd
In-Reply-To: <430C7F13.8090902@savoirtech.com>
Message-ID: <Pine.LNX.4.58.0508241030540.12315@saturn.opentools.org>
References: <20050824044222.26844.qmail@minotaur.apache.org>
 <9c827e47c3f6aec9c6309b730e7d13ef@yahoo.com>
 <430C7DE1.9030705@savoirtech.com>
 <Pine.LNX.4.58.0508241019370.12315@saturn.opentools.org>
 <430C7F13.8090902@savoirtech.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

	Well, you're free to wait for more input, that's just my 2 
cents... :)

Aaron

On Wed, 24 Aug 2005, Jeff Genender wrote:
> No problem...I'll fix it in a jiffy.
> 
> Aaron Mulder wrote:
> > 	I would prefer present/not present to true/false/missing.  I don't
> > think it's clear what missing means -- as far as an end user is concerned
> > the default could go either way, so it just adds to our documentation
> > requirements.
> > 
> > Aaron
> > 
> > On Wed, 24 Aug 2005, Jeff Genender wrote:
> > 
> >>6 of one / half-dozen of the other.  I am just following the same 
> >>paradigm as the initParams (and how Tomcat attributes work).  Missing is 
> >>the same as false.  If there are strong feelings of doing it the other 
> >>way, I am more than happy to back out the xsd.  I just wanted things to 
> >>be consistent.
> >>
> >>Would you prefer that I back it out?  I have no strong feelings either way.
> >>
> >>Jeff
> >>
> >>David Jencks wrote:
> >>
> >>>Out of curiousity, why do you think explicit true/false is better than  
> >>>missing == false, <cross-context/> == true?  My thinking in using the  
> >>>latter was that it is unambiguous, whereas with an optional true/false  
> >>>value, what does missing mean?  This is not a big deal, I just wonder  
> >>>what your reasoning is.
> >>>
> >>>thanks
> >>>david jencks
> >>>
> >>>On Aug 23, 2005, at 9:42 PM, jgenender@apache.org wrote:
> >>>
> >>>
> >>>>Author: jgenender
> >>>>Date: Tue Aug 23 21:42:17 2005
> >>>>New Revision: 239527
> >>>>
> >>>>URL: http://svn.apache.org/viewcvs?rev=239527&view=rev
> >>>>Log:
> >>>>Updates the xsd for true false and added in the eclipse stuff
> >>>>
> >>>>Modified:
> >>>>    geronimo/trunk/modules/tomcat-builder/project.properties
> >>>>     geronimo/trunk/modules/tomcat-builder/src/schema/geronimo-tomcat.xsd
> >>>>
> >>>>Modified: geronimo/trunk/modules/tomcat-builder/project.properties
> >>>>URL:  
> >>>>http://svn.apache.org/viewcvs/geronimo/trunk/modules/tomcat-builder/ 
> >>>>project.properties?rev=239527&r1=239526&r2=239527&view=diff
> >>>>======================================================================= 
> >>>>=======
> >>>>--- geronimo/trunk/modules/tomcat-builder/project.properties (original)
> >>>>+++ geronimo/trunk/modules/tomcat-builder/project.properties Tue Aug  
> >>>>23 21:42:17 2005
> >>>>@@ -5,4 +5,7 @@
> >>>>  maven.junit.jvmargs=-Djava.security.auth.login.config=src/test- 
> >>>>resources/data/login.config -ea
> >>>> maven.junit.fork=true
> >>>>
> >>>>+# Include the generated xmlbean classes in the eclipse classpath
> >>>>+maven.eclipse.classpath.include=${basedir}/target/ 
> >>>>xmlbeans,${basedir}/target/xmlbeans-classes
> >>>>+
> >>>> maven.idea.generated.source=xmlbeans
> >>>>
> >>>>Modified:  
> >>>>geronimo/trunk/modules/tomcat-builder/src/schema/geronimo-tomcat.xsd
> >>>>URL:  
> >>>>http://svn.apache.org/viewcvs/geronimo/trunk/modules/tomcat-builder/ 
> >>>>src/schema/geronimo-tomcat.xsd? rev=239527&r1=239526&r2=239527&view=diff
> >>>>======================================================================= 
> >>>>=======
> >>>>---  
> >>>>geronimo/trunk/modules/tomcat-builder/src/schema/geronimo-tomcat.xsd  
> >>>>(original)
> >>>>+++  
> >>>>geronimo/trunk/modules/tomcat-builder/src/schema/geronimo-tomcat.xsd  
> >>>>Tue Aug 23 21:42:17 2005
> >>>>@@ -29,12 +29,17 @@
> >>>>     <xs:complexType name="tomcat-configType">
> >>>>         <xs:sequence>
> >>>>             <xs:element name="host" type="xs:string" minOccurs="0"/>
> >>>>-            <xs:element name="cross-context" type="tomcat:emptyType"  
> >>>>minOccurs="0"/>
> >>>>+            <xs:element name="cross-context"  
> >>>>type="tomcat:trueFalseType" minOccurs="0"/>
> >>>>             <xs:element name="valve-chain" type="xs:string"  
> >>>>minOccurs="0"/>
> >>>>             <xs:element name="tomcat-realm" type="xs:string"  
> >>>>minOccurs="0"/>
> >>>>         </xs:sequence>
> >>>>     </xs:complexType>
> >>>>
> >>>>-    <xs:complexType name="emptyType"/>
> >>>>-
> >>>>+    <xs:simpleType name="trueFalseType">
> >>>>+        <xs:restriction base="xs:string">
> >>>>+            <xs:enumeration value="true"/>
> >>>>+            <xs:enumeration value="false"/>
> >>>>+        </xs:restriction>
> >>>>+    </xs:simpleType>
> >>>>+
> >>>> </xs:schema>
> >>>>
> >>>>
>