geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Bohn (JIRA)" <>
Subject [jira] Updated: (GERONIMO-846) Log Level set on Console is overridden by serverlog properties setting even if the properties setting hasn't changed.
Date Wed, 03 Aug 2005 21:02:37 GMT
     [ ]

Joe Bohn updated GERONIMO-846:

    Attachment: logSettings.diff

I've updated both the LogManagerPortlet to only invoke methods to change items in the Logger
if a change has in fact been made at the console.  
I've also updated the Log4jService so that it will not attempt to make a change unless the
value of the new attribute has in fact been changed.  
I did this for the root level, root properties file, and root refresh interval.   We could/should
probably make similar changes for the other loggers.
The last update will now win (either from the GUI or via an edit on the properties file) and
any changes made from the GUI will be active until the
next recycle of the server (or change in the file).

> Log Level set on Console is overridden by serverlog properties setting even if the properties
setting hasn't changed.
> ---------------------------------------------------------------------------------------------------------------------
>          Key: GERONIMO-846
>          URL:
>      Project: Geronimo
>         Type: Bug
>   Components: management, common
>     Versions: 1.0-M4
>  Environment: Windows XP
>     Reporter: Joe Bohn
>  Attachments: logSettings.diff
> Each update action from the LogManagerPortlet invokes the appropriate 3 methods on the
SystemLog without checking for actual changes in the submitted values.   For the refresh interval
this isn't a problem because Log4JService checks itself to ensure the period has changed before
updating the value.  For the logging level this also isn't a problem because there is no ill
effect to updating the level with the exact same level.   However, when setting the ConfigFileName
the Log4JService doesn't check the value and assumes that there really is a new file and therefore
sets the lastChanged value to -1 to ensure that the file values will take effect on the next
timer refresh.  The result is that any change (including only a change to the logging level)
from the console also guarantees that the file settings will be refreshed. 
> I propose the following:
> 1) Change the LogManagerPortlet to ensure that the name or level has changed before updating
the SystemLog (Log4JService) ... I'd also ensure that we check for changes in the refresh
period as well just for good measure.  This way we won't was time setting things that haven't
> 2) Change the Log4JService to always check for an actual change to the level and/or the
configPathName before taking any real action (just as it does for refresh interval today).
 This will clean things up so that another object invoking this service unnecessarily doesn't
create a similar problem.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message