geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick McGuire (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Date Thu, 04 Aug 2005 10:06:36 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-640?page=comments#action_12317610 ] 

Rick McGuire commented on GERONIMO-640:
---------------------------------------

Aaron, I had some discussions about FileURLConnection last week with David Blevins and David
Jencks on another issue, and we came to the conclusion that the support this class offers
over and above the default file connection protocol was not being used be Geronimo.  I've
been doing some build and test experiments with this this class removed over the last couple
of days and this does appear to be true.  If this class really needs repairing, then a better
solution would probably be to get rid of it entirely. 

> Remove dependency on Sun internals code for URL decoding
> --------------------------------------------------------
>
>          Key: GERONIMO-640
>          URL: http://issues.apache.org/jira/browse/GERONIMO-640
>      Project: Geronimo
>         Type: Improvement
>     Versions: 1.0-M3
>     Reporter: Tim Ellison
>      Fix For: 1.0-M5
>  Attachments: decode-patch.txt
>
> [Looking at 1.0-M3 source code]
> The Geronimo types:
>   org.apache.geronimo.system.url.file.Handler
> and
>   org.apache.geronimo.system.url.file.FileURLConnection
> both import and use the Sun non-API type "sun.net.www.ParseUtil".  It appears that the
usage is quite trivial, and can easily be replaced by API calls on URLDecoder.  This will
remove a JRE-implementation dependency.
> The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil,
so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to
"a b" whereas ParseUtil leaves it as "a+b".  Is this difference in decoding behavior expected
by Geronimo?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message