Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 772 invoked from network); 27 Jul 2005 23:23:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 27 Jul 2005 23:23:58 -0000 Received: (qmail 55060 invoked by uid 500); 27 Jul 2005 23:23:50 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 54978 invoked by uid 500); 27 Jul 2005 23:23:49 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 54869 invoked by uid 99); 27 Jul 2005 23:23:49 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=SPF_FAIL X-Spam-Check-By: apache.org Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jul 2005 16:23:37 -0700 Received: from ajax.apache.org (ajax.apache.org [127.0.0.1]) by ajax.apache.org (Postfix) with ESMTP id 29FC1EA for ; Thu, 28 Jul 2005 01:23:21 +0200 (CEST) Message-ID: <2100761301.1122506601170.JavaMail.jira@ajax.apache.org> Date: Thu, 28 Jul 2005 01:23:21 +0200 (CEST) From: "David Jencks (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Closed: (GERONIMO-824) MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization In-Reply-To: <1605529912.1122492140042.JavaMail.jira@ajax.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/GERONIMO-824?page=all ] David Jencks closed GERONIMO-824: --------------------------------- Fix Version: 1.0-M4 Resolution: Fixed m4 fix: Checking in modules/openejb-builder/src/java/org/openejb/deployment/MdbBuilder.java; new revision: 1.20.4.2; previous revision: 1.20.4.1 > MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization > ---------------------------------------------------------------------------- > > Key: GERONIMO-824 > URL: http://issues.apache.org/jira/browse/GERONIMO-824 > Project: Geronimo > Type: Bug > Components: OpenEJB > Versions: 1.0-M3 > Reporter: Matt Hogstrom > Assignee: David Jencks > Fix For: 1.0-M5, 1.0-M4 > > org.openejb.deployment.MdbBuilder.java assigns null to the ListenerType if the type cannot be determined. This causes runtime errors that are manifested in the MdbContainerBuilder as Null Pointer Exceptions. > This fix assigns a type of javax.jms.MessageListener to the interface type as a default. > Index: MdbBuilder.java > =================================================================== > RCS file: /home/projects/openejb/scm/openejb/modules/openejb-builder/src/java/org/openejb/deployment/MdbBuilder.java,v > retrieving revision 1.21 > diff -r1.21 MdbBuilder.java > 173c173,179 > < builder.setEndpointInterfaceName(OpenEJBModuleBuilder.getJ2eeStringValue(messageDrivenBean.getMessagingType())); > --- > > String messageInterfaceType = null; > > if (messageDrivenBean.isSetMessagingType()) { > > messageInterfaceType = messageDrivenBean.getMessagingType().getStringValue().trim(); > > } else { > > messageInterfaceType = "javax.jms.MessageListener"; > > } > > builder.setEndpointInterfaceName(messageInterfaceType); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira