geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Mulder <ammul...@alumni.princeton.edu>
Subject Re: [jira] Created: (GERONIMO-702) Can't set listen host/IP for Tomcat Connectors
Date Mon, 04 Jul 2005 23:15:49 GMT
Jeff,
	I'd like to remove the host and port fron the initParams block and
make separate GBean attributes for them.  Then in the GBean constructor,
we can put the appropriate name/value pairs into the initParams before
applying them.  I think it would be best to work toward as many GBean
attributes as we can at the expense of blocks of XML or Properties or
whatever.  Is that OK with you?

	In fact, maybe we should just go ahead and make GBean attributes 
for all the values you can list in the initParams section.  But right now, 
it's the host and port I care about most.

	Also, I haven't checked in the getAddress method yet, so that bit 
of the JIRA report may not make too much sense.  :)

Thanks,
	Aaron

On Mon, 4 Jul 2005, Jeff Genender wrote:
> Aaron,
> 
> I am confident we handle this.  The ConnectorGBean is a simply a GBean 
> proxy for the Tomcat Connector object.  You can declaritively change the 
> ip address to listen on with an initParam called "address" in the GBean 
> configuration.  See here for an example of how this would be done in our 
> j2ee-server-tomcat-plan.xml using 192.168.0.1:
> 
> <gbean name="TomcatWebConnector" 
> class="org.apache.geronimo.tomcat.ConnectorGBean">
>          <attribute name="initParams">
>              address=192.168.0.1
>              port=${PlanTomcatHTTPPort}
>              maxHttpHeaderSize=8192
>              maxThreads=150
>              minSpareThreads=25
>              maxSpareThreads=75
>              enableLookups=false
>              redirectPort=${PlanTomcatHTTPSPort}
>              acceptCount=100
>              connectionTimeout=20000
>              disableUploadTimeout=true
>          </attribute>
>          <reference name="TomcatContainer">
>              <name>TomcatWebContainer</name>
>          </reference>
> </gbean>
> 
> Since we are proxying the call to the Connector object, we support and 
> pass on all Tomcat configurations to the Tomcat engine as listed here: 
> http://jakarta.apache.org/tomcat/tomcat-5.5-doc/config/http.html.  So, 
> IMHO, I believe we support this for Tomcat.
> 
> Does this handle the concern?
> 
> Thanks,
> 
> Jeff
> 
> 
> Aaron Mulder (JIRA) wrote:
> > Can't set listen host/IP for Tomcat Connectors
> > ----------------------------------------------
> > 
> >          Key: GERONIMO-702
> >          URL: http://issues.apache.org/jira/browse/GERONIMO-702
> >      Project: Geronimo
> >         Type: Bug
> >   Components: Tomcat  
> >     Versions: 1.0-M3    
> >     Reporter: Aaron Mulder
> > 
> > 
> > Currently the Tomcat network connector GBean lets you specify the port to listen
on, but not the host/IP.  Both should be allowed.  The class in question is:
> > 
> > geronimo/modules/tomcat/org/apache/geronimo/tomcat/ConnectorGBean
> > 
> > When this is done, the getAddress method on that class should be changed to return
the correct listen address instead of being hardcoded to return "0.0.0.0" and the relevant
port.
> > 
> 

Mime
View raw message