Return-Path: 
 <dev-return-12511-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 79943 invoked from network); 18 May 2005 04:57:05 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 18 May 2005 04:57:05 -0000
Received: (qmail 68943 invoked by uid 500); 18 May 2005 02:00:32 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 68832 invoked by uid 500); 18 May 2005 02:00:29 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 68583 invoked by uid 99); 18 May 2005 02:00:27 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Received: from Unknown (HELO mgd.gluecode.com) (64.14.202.141)
  by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 17 May 2005 19:00:25 -0700
Received: from [192.168.1.5] (dsl093-038-137.pdx1.dsl.speakeasy.net
 [66.93.38.137])
	(authenticated bits=0)
	by mgd.gluecode.com (8.12.10/8.12.10) with ESMTP id j4I1xnCW030661
	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO)
	for <dev@geronimo.apache.org>; Tue, 17 May 2005 18:59:52 -0700
Mime-Version: 1.0 (Apple Message framework v619.2)
In-Reply-To: <20050517200455.GA27142@caboteria.org>
References: <1639797690.1115836639152.JavaMail.jira@ajax.apache.org>
 <20050517200455.GA27142@caboteria.org>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <7f4a0c6ae2c599ab646674dc75a059ac@gluecode.com>
Content-Transfer-Encoding: 7bit
From: David Jencks <djencks@gluecode.com>
Subject: Re: [jira] Created: (GERONIMO-645) geronimo/jetty doesn't respect
 web.xml load-on-startup order
Date: Tue, 17 May 2005 19:00:12 -0700
To: dev@geronimo.apache.org
X-Mailer: Apple Mail (2.619.2)
X-Virus-Checked: Checked
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Certainly the simplest solution is to give JettyServletHolder a 
Previous reference so they form a linked list and set this reference in 
the builder so as to be consistent with and enforce the startup order.  
The  JettyFilterMapping uses this idea and I admit I thought I had 
implemented it for servlet holder also :-(

thanks
david jencks
On May 17, 2005, at 1:04 PM, toby cabot wrote:

> On Wed, May 11, 2005 at 08:37:19PM +0200, toby cabot (JIRA) wrote:
>> Geronimo doesn't appear to start servlets in the order specified
>> by <load-on-startup>.
>
> I started looking at this but I think I've gone as far as I can
> without some advice.  I started by modifying JettyModuleBuilder to
> create the servlet gbeans in the order specified by the
> load-on-startup elements, and that worked the first time I ran the
> server.  But not the second time.  So I looked into it a little more
> and found that the BasicDependencyManager stores the dependencies as a
> set, so when GBeanInstanceState.startRecursive() gets the children (in
> this case the servlets) to start there's no order to them.
>
> So I'm at a loss for what to do.  Modifying the dependency manager to
> use lists instead of sets seems pretty drastic (since some of the
> methods return sets) but it would probably make the server start up
> more predictably.  But I'm not sure that's enough to ensure that the
> load-on-startup order is respected all the way through deployment and
> startup.
>
> If anyone has any ideas I'd be happy to put some more legwork into
> this.
>
> Thanks,
> Toby
>
> PS.  Ordinarily I'd add comments like this to Jira but it's down:
>
> Proxy Error
>
> The proxy server received an invalid response from an upstream server.
> The proxy server could not handle the request GET 
> /jira/secure/BrowseProject.jspa.
>
> Reason: Error reading from remote server
>
> Apache/2.0.54 (Unix) mod_ssl/2.0.54 OpenSSL/0.9.7a DAV/2 SVN/1.2.0-dev 
> Server at issues.apache.org Port 80
>