geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeremy Boynes (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-640) Remove dependency on Sun internals code for URL decoding
Date Fri, 29 Apr 2005 13:52:06 GMT
     [ http://issues.apache.org/jira/browse/GERONIMO-640?page=comments#action_64065 ]
     
Jeremy Boynes commented on GERONIMO-640:
----------------------------------------

Thanks for the patch

I'm curious though what this class is doing - wouldn't it now be sufficient to convert the
URL to a File using

File file = new File(new URI(url.toString());

> Remove dependency on Sun internals code for URL decoding
> --------------------------------------------------------
>
>          Key: GERONIMO-640
>          URL: http://issues.apache.org/jira/browse/GERONIMO-640
>      Project: Geronimo
>         Type: Improvement
>     Versions: 1.0-M3
>     Reporter: Tim Ellison
>  Attachments: decode-patch.txt
>
> [Looking at 1.0-M3 source code]
> The Geronimo types:
>   org.apache.geronimo.system.url.file.Handler
> and
>   org.apache.geronimo.system.url.file.FileURLConnection
> both import and use the Sun non-API type "sun.net.www.ParseUtil".  It appears that the
usage is quite trivial, and can easily be replaced by API calls on URLDecoder.  This will
remove a JRE-implementation dependency.
> The only caveat is that simple tests show that URLDecoder decodes 'more' than the ParseUtil,
so while both methods will convert "a%20b" to "a b"; the URLDecoder will convert "a+b" to
"a b" whereas ParseUtil leaves it as "a+b".  Is this difference in decoding behavior expected
by Geronimo?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message