geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dondi Imperial (JIRA)" <>
Subject [jira] Updated: (GERONIMO-637) LogFactory.release(ClassLoader) can release the parent config's logger.
Date Wed, 27 Apr 2005 04:59:28 GMT
     [ ]

Dondi Imperial updated GERONIMO-637:

    Attachment: diff.txt

It looks like release in o.a.g.kernel.log.GeronimoLogFactory sets all of it's contained Logs
(wrapped in instances of GeronimoLog) to null in release. This doesn't seem to be necessary
and will even cause NullPointerExceptions when classes that continue to hold references to
these Logs call one of their methods. It seems like this is done so Logs can get garbage collected
but this might not be correct because some objects might still be holding references to there
Logs. Attached here is a patch that removes the code described previously. 

> LogFactory.release(ClassLoader) can release the parent config's logger.
> -----------------------------------------------------------------------
>          Key: GERONIMO-637
>          URL:
>      Project: Geronimo
>         Type: Bug
>   Components: general
>     Reporter: Dondi Imperial
>     Priority: Minor
>  Attachments: diff.txt, test.war
> Calling LogFactory.release(ClassLoader) from a configuration appears to release the parent
config's logger.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message