geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gianny DAMOUR (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-587) deployer can fail but appear to succeed
Date Sun, 27 Mar 2005 08:13:17 GMT
     [ http://issues.apache.org/jira/browse/GERONIMO-587?page=comments#action_61588 ]
     
Gianny DAMOUR commented on GERONIMO-587:
----------------------------------------

Hello Toby,

First of all, thanks for this patch!

There is definitively a bug. Your patch fixes this problem; yet, it also introduces a side-effect
that I would like you to fix.

Basically, if one throws a DeploymentException in waitForProgress, then the  method does not
return any more the TargetModuleID correctly operated.

For instance, if one starts two times the debug console to exhibit such a behavior, I get
(after your patch):
"
$ java -jar bin/deployer.jar --user system --password manager start org/apache/geronimo/DebugConsole
org/apache/geronimo/DebugConsole
    Error: Deployment failed, Server reports: Unable to register
    configuration
    An MBean is already registered under the name
    geronimo.config:name="org/apache/geronimo/DebugConsole"
"

Without our patch:
"
$ java -jar bin/deployer.jar --user system --password manager start org/apache/geronimo/DebugConsole
org/apache/geronimo/DebugConsole
Deployment failed
  Server reports: Unable to register configuration
An MBean is already registered under the name geronimo.config:name="org/apache/geronimo/DebugConsole"

Started org/apache/geronimo/DebugConsole
"

As you can see, the deployer reports that debug console has been started.

Could you please have a look to this side-effect and provide another patch?

Thanks!

> deployer can fail but appear to succeed
> ---------------------------------------
>
>          Key: GERONIMO-587
>          URL: http://issues.apache.org/jira/browse/GERONIMO-587
>      Project: Geronimo
>         Type: Bug
>   Components: deployment
>     Versions: 1.0-M3
>  Environment: fedora core 2
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2_04-b05)
>     Reporter: toby cabot
>     Assignee: Gianny DAMOUR
>     Priority: Minor
>  Attachments: deployer-error-patch.txt
>
> If you run the deployer "distribute" command, but have a copy of Geronimo running on
the same machine, the command fails but returns 0 so any ant/shell script that runs it thinks
it succeded.  I'll attach a patch that fixes the second problem, i.e. when it fails for this
reason it will return non-zero.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message