geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sisson (JIRA)" <...@geronimo.apache.org>
Subject [jira] Updated: (GERONIMO-607) Logging configuration is unnecessarily processed twice at startup
Date Fri, 11 Mar 2005 08:47:52 GMT
     [ http://issues.apache.org/jira/browse/GERONIMO-607?page=history ]

John Sisson updated GERONIMO-607:
---------------------------------

    Description: 
The following currently occurs when Geronimo is started:

1. Geronimo bootstraps logging to the console as part of the static initialisation in the
Daemon class.

2. The Log4j service GBean org.apache.geronimo.system.logging.log4j.Log4jService's doStart()
is called, which in turn calls Log4jService.reconfigure() which in turn causes Log4j's to
be configured, therefore opening geronimo.log.  Log4jService.doStart() also starts a timer
for monitoring modifications to the log configuration file.

3. The timer pops for the first time and since the "lastchanged" variable is -1 the statement
at line 411 of Log4jService causes the logging to be reconfigured (log file is closed and
reopened) even though the logging configuration wasn't changed:

                if (lastChanged < lastModified) {
                    lastChanged = lastModified;
                    reconfigure();
                }

  was:
The following currently occurs when Geronimo is started:

1. Geronimo bootstraps logging to console as part of the static initialisation in the Daemon
class.

2. The Log4j service GBean's Log4jService.doStart() is called, which in turn calls Log4jService.reconfigure()
which in turn causes Log4j's to be configured, therefore opening geronimo.log.  Log4jService.doStart()
also starts a timer for monitoring modifications to the log configuration file.

3. The timer pops for the first time and since the "lastchanged" variable is -1 the statement
at line 411 of org.apache.geronimo.system.logging.log4j.Log4jService causes the logging to
be reconfigured (even though the logging configuration wasn't changed):

                if (lastChanged < lastModified) {
                    lastChanged = lastModified;
                    reconfigure();
                }


> Logging configuration is unnecessarily processed twice at startup
> -----------------------------------------------------------------
>
>          Key: GERONIMO-607
>          URL: http://issues.apache.org/jira/browse/GERONIMO-607
>      Project: Geronimo
>         Type: Bug
>     Reporter: John Sisson
>     Priority: Minor
>  Attachments: Log4jService_patch.txt
>
> The following currently occurs when Geronimo is started:
> 1. Geronimo bootstraps logging to the console as part of the static initialisation in
the Daemon class.
> 2. The Log4j service GBean org.apache.geronimo.system.logging.log4j.Log4jService's doStart()
is called, which in turn calls Log4jService.reconfigure() which in turn causes Log4j's to
be configured, therefore opening geronimo.log.  Log4jService.doStart() also starts a timer
for monitoring modifications to the log configuration file.
> 3. The timer pops for the first time and since the "lastchanged" variable is -1 the statement
at line 411 of Log4jService causes the logging to be reconfigured (log file is closed and
reopened) even though the logging configuration wasn't changed:
>                 if (lastChanged < lastModified) {
>                     lastChanged = lastModified;
>                     reconfigure();
>                 }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message