Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 18590 invoked from network); 23 Feb 2005 01:04:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 23 Feb 2005 01:04:14 -0000 Received: (qmail 5184 invoked by uid 500); 23 Feb 2005 01:04:10 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 5148 invoked by uid 500); 23 Feb 2005 01:04:10 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 5132 invoked by uid 99); 23 Feb 2005 01:04:10 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from Unknown (HELO mgd.gluecode.com) (64.14.202.141) by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 22 Feb 2005 17:04:09 -0800 Received: from [192.168.15.104] (69-160-150-15.vnnyca.adelphia.net [69.160.150.15]) (authenticated bits=0) by mgd.gluecode.com (8.12.10/8.12.10) with ESMTP id j1N13JCW017156 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO) for ; Tue, 22 Feb 2005 17:03:19 -0800 Mime-Version: 1.0 (Apple Message framework v619.2) In-Reply-To: <20050221211909.67281.qmail@minotaur.apache.org> References: <20050221211909.67281.qmail@minotaur.apache.org> Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <7c1b7d42812d1a853f80334f1d89c8a5@gluecode.com> Content-Transfer-Encoding: 7bit From: Dain Sundstrom Subject: Re: svn commit: r154723 - in geronimo/trunk/modules/kernel/src: java/org/apache/geronimo/gbean/GBeanName.java test/org/apache/geronimo/gbean/GBeanNameTest.java Date: Tue, 22 Feb 2005 17:04:03 -0800 To: dev@geronimo.apache.org X-Mailer: Apple Mail (2.619.2) X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N I think we will need a canonical form. There are many places that key stuff off the string canonical form of the object name. I think that instead of keeping the original name around, we throw it out and replace it with canonical name form, since the original name doesn't really matter. Also I would hope the canonical form is the same as object name. One other thing, it doesn't look like this is escaping key values, or checking for illegal characters. -dain -- Dain Sundstrom Chief Architect Gluecode Software 310.536.8355, ext. 26