geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-383) xmlbeans magic allows us to accept some invalid deployment descriptors
Date Sat, 05 Feb 2005 04:23:25 GMT
     [ http://issues.apache.org/jira/browse/GERONIMO-383?page=comments#action_58619 ]
     
David Jencks commented on GERONIMO-383:
---------------------------------------

Progress towards this goal, mostly in rev 151477 and 151327.

All builders now assume a file with the correct name to be their dd is their dd, and throw
an exception if they can't parse it.  This should fix most of the mysterious "Syntax error
or no deployer found" erros.

Ejb dd parsing now checks for the 1.4 namespace and does not munge if present, and checks
that a dtd is one of the two legal possibilities.  

> xmlbeans magic allows us to accept some invalid deployment descriptors
> ----------------------------------------------------------------------
>
>          Key: GERONIMO-383
>          URL: http://issues.apache.org/jira/browse/GERONIMO-383
>      Project: Apache Geronimo
>         Type: Bug
>   Components: deployment
>     Versions: 1.0-M2
>     Reporter: David Jencks
>     Assignee: David Jencks

>
> The element reordering and other xmlbeans magic we do to convert pre-1.4 deployment descriptors
to 1.4 versions can have the unintended side effect of converting invalid 1.4 descriptors
to valid ones.  This has been fixed in SchemaConversionUtils.convertToServletSchema for servlet
1.3 web.xml.  We should apply this same fix of checking for namespace before conversion to
other modules (ejb etc) and extend the checking to:
> 1. look for the DOCTYPE using xmlbeans
> 2. converting to a made-up namespace for that dtd
> 3. validating against xmlbeans objects for the schema corresponding to the dtd.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message