geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark <delafran_j...@hotmail.com>
Subject ServerInfo
Date Thu, 06 Jan 2005 20:51:59 GMT
Looking at the recent checkin for ServerInfo.java

Revision *124261* </viewcvs.cgi?rev=124261&view=rev> - (view 
</viewcvs.cgi/geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/serverinfo/ServerInfo.java?rev=124261&view=markup>)

(download 
</viewcvs.cgi/*checkout*/geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/serverinfo/ServerInfo.java?rev=124261>)

- *[selected]*
Modified /Wed Jan 5 19:56:08 2005 UTC/ (24 hours, 43 minutes ago) by /dain/
File length: 5373 byte(s)
Diff to previous 123908 
</viewcvs.cgi/geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/serverinfo/ServerInfo.java?rev=124261&r1=123908&r2=124261>

(colored 
</viewcvs.cgi/geronimo/trunk/modules/system/src/java/org/apache/geronimo/system/serverinfo/ServerInfo.java?rev=124261&r1=123908&r2=124261&diff_format=h>)



Commented out test using listRoots as it doesn't work on windows computers cotaining a floppy
drive a:. 
Removed setting of geronimo.base.dir system property as it stops the ability to start two
server info 
objects in the same vm (even if they are started one after the other). 
Also no one was getting the property anyway.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

It is being used by the log4j configuration files:

see var/log/server-log4j.properties:

log4j.appender.FILE.file=${geronimo.base.dir}/var/log/geronimo.log

I would think that if the multiple server info objects all have the same base.dir then the
system property should be ok.  If the multiple server info objects are designed to allow descriptions
of servers with different base.dirs then we need a way to configure two different log4j server
logs.  If the servers are named then server info could set a named base.dir which could then
be used by log4j.

Thanks
Mark




Mime
View raw message