Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 25422 invoked from network); 10 Dec 2004 18:48:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 10 Dec 2004 18:48:11 -0000 Received: (qmail 67701 invoked by uid 500); 10 Dec 2004 18:48:03 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 67662 invoked by uid 500); 10 Dec 2004 18:48:03 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@geronimo.apache.org Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 67646 invoked by uid 99); 10 Dec 2004 18:48:03 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from Unknown (HELO mgd.gluecode.com) (64.14.202.141) by apache.org (qpsmtpd/0.28) with ESMTP; Fri, 10 Dec 2004 10:48:02 -0800 Received: from [209.152.54.175] ([209.152.54.175]) (authenticated bits=0) by mgd.gluecode.com (8.12.10/8.12.10) with ESMTP id iBAIljCW031973 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO) for ; Fri, 10 Dec 2004 10:47:48 -0800 Mime-Version: 1.0 (Apple Message framework v619) In-Reply-To: References: Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <0011FB0A-4ADC-11D9-B4D1-000D93361CAA@gluecode.com> Content-Transfer-Encoding: 7bit From: David Jencks Subject: Re: svn commit: r111366 - in geronimo/branches/djencks/jetty-deployer1/trunk/modules: jetty/src/test/org/apache/geronimo/jetty security/src/java/org/apache/geronimo/security/jacc Date: Fri, 10 Dec 2004 10:47:53 -0800 To: dev@geronimo.apache.org X-Mailer: Apple Mail (2.619) X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N On Dec 10, 2004, at 10:30 AM, Alan D. Cabrera wrote: > I guess we interpreted the spec differently. Shall we let the TCK > decide? sure > > I didn't realize that we were done w/ the jetty "clean up". Shall we > delete this branch? sure. Will do so soon. thanks david > > > Regards, > Alan > > -----Original Message----- > From: David Jencks [mailto:djencks@gluecode.com] > Sent: Thu 12/9/2004 10:23 AM > To: dev@geronimo.apache.org > Cc: > Subject: Re: svn commit: r111366 - in > geronimo/branches/djencks/jetty-deployer1/trunk/modules: > jetty/src/test/org/apache/geronimo/jetty > security/src/java/org/apache/geronimo/security/jacc > > > > Did you mean to revert these to the previous, IMNSHO very broken, > code? > I don't see any code that assures us that we will always get the > same > PolicyConfiguration instance back from > PolicyConfigurationFactory.getPolicyConfiguration as required by the > spec. > > Also, please apply any modifications to trunk, not this branch, which > I > want to delete as soon as I'm convinced I didn't miss anything. > > thanks > david jencks > > On Dec 9, 2004, at 12:43 AM, adc@apache.org wrote: > > > > Modified: > > > geronimo/branches/djencks/jetty-deployer1/trunk/modules/security/src/ > > java/org/apache/geronimo/security/jacc/ > > GeronimoPolicyConfiguration.java > > Url: > > http://svn.apache.org/viewcvs/geronimo/branches/djencks/jetty- > > deployer1/trunk/modules/security/src/java/org/apache/geronimo/ > > security/jacc/GeronimoPolicyConfiguration.java? > > view=diff&rev=111366&p1=geronimo/branches/djencks/jetty-deployer1/ > > trunk/modules/security/src/java/org/apache/geronimo/security/jacc/ > > GeronimoPolicyConfiguration.java&r1=111365&p2=geronimo/branches/ > > djencks/jetty-deployer1/trunk/modules/security/src/java/org/apache/ > > geronimo/security/jacc/GeronimoPolicyConfiguration.java&r2=111366 > > > ======================================================================= > > ======= > > --- > > > geronimo/branches/djencks/jetty-deployer1/trunk/modules/security/src/ > > java/org/apache/geronimo/security/jacc/ > > GeronimoPolicyConfiguration.java (original) > > +++ > > > geronimo/branches/djencks/jetty-deployer1/trunk/modules/security/src/ > > java/org/apache/geronimo/security/jacc/ > > GeronimoPolicyConfiguration.java Thu Dec 9 00:43:32 2004 > > @@ -29,6 +29,6 @@ > > public interface GeronimoPolicyConfiguration extends > > RoleMappingConfiguration { > > public boolean implies(ProtectionDomain domain, Permission > > permission); > > > > - public void open(boolean remove); > > + public void open(); > > > > } > > > > Modified: > > > geronimo/branches/djencks/jetty-deployer1/trunk/modules/security/src/ > > java/org/apache/geronimo/security/jacc/ > > GeronimoPolicyConfigurationFactory.java > > Url: > > http://svn.apache.org/viewcvs/geronimo/branches/djencks/jetty- > > deployer1/trunk/modules/security/src/java/org/apache/geronimo/ > > security/jacc/GeronimoPolicyConfigurationFactory.java? > > view=diff&rev=111366&p1=geronimo/branches/djencks/jetty-deployer1/ > > trunk/modules/security/src/java/org/apache/geronimo/security/jacc/ > > GeronimoPolicyConfigurationFactory.java&r1=111365&p2=geronimo/ > > > branches/djencks/jetty-deployer1/trunk/modules/security/src/java/org/ > > apache/geronimo/security/jacc/ > > GeronimoPolicyConfigurationFactory.java&r2=111366 > > > ======================================================================= > > ======= > > --- > > > geronimo/branches/djencks/jetty-deployer1/trunk/modules/security/src/ > > java/org/apache/geronimo/security/jacc/ > > GeronimoPolicyConfigurationFactory.java (original) > > +++ > > > geronimo/branches/djencks/jetty-deployer1/trunk/modules/security/src/ > > java/org/apache/geronimo/security/jacc/ > > GeronimoPolicyConfigurationFactory.java Thu Dec 9 00:43:32 > 2004 > > @@ -51,11 +51,11 @@ > > public PolicyConfiguration getPolicyConfiguration(String > > contextID, boolean remove) throws PolicyContextException { > > GeronimoPolicyConfiguration configuration = > > (GeronimoPolicyConfiguration) configurations.get(contextID); > > > > - if (configuration == null) { > > + if (configuration == null || remove) { > > configuration = new > PolicyConfigurationGeneric(contextID); > > configurations.put(contextID, configuration); > > } else { > > - configuration.open(remove); > > + configuration.open(); > > } > > > > return configuration; > > > > Modified: > > > geronimo/branches/djencks/jetty-deployer1/trunk/modules/security/src/ > > > java/org/apache/geronimo/security/jacc/PolicyConfigurationGeneric.java > > Url: > > http://svn.apache.org/viewcvs/geronimo/branches/djencks/jetty- > > deployer1/trunk/modules/security/src/java/org/apache/geronimo/ > > security/jacc/PolicyConfigurationGeneric.java? > > view=diff&rev=111366&p1=geronimo/branches/djencks/jetty-deployer1/ > > trunk/modules/security/src/java/org/apache/geronimo/security/jacc/ > > PolicyConfigurationGeneric.java&r1=111365&p2=geronimo/branches/ > > djencks/jetty-deployer1/trunk/modules/security/src/java/org/apache/ > > geronimo/security/jacc/PolicyConfigurationGeneric.java&r2=111366 > > > ======================================================================= > > ======= > > --- > > > geronimo/branches/djencks/jetty-deployer1/trunk/modules/security/src/ > > > java/org/apache/geronimo/security/jacc/PolicyConfigurationGeneric.java > > (original) > > +++ > > > geronimo/branches/djencks/jetty-deployer1/trunk/modules/security/src/ > > > java/org/apache/geronimo/security/jacc/PolicyConfigurationGeneric.java > > Thu Dec 9 00:43:32 2004 > > @@ -222,14 +222,7 @@ > > > > //TODO I have no idea what side effects this might have, but > it's > > needed in some form from GeronimoPolicyConfigurationFactory. > > //see JACC spec 1.0 section 3.1.1.1 discussion of in service > and > > deleted. > > - public void open(boolean remove) { > > - if (remove) { > > - rolePermissionsMap.clear(); > > - principalRoleMapping.clear(); > > - unchecked = null; > > - excluded = null; > > - principalPermissionsMap.clear(); > > - } > > + public void open() { > > state = OPEN; > > } > > } > > > > >