From dev-return-9743-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org Tue Nov 02 12:29:46 2004 Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 96461 invoked from network); 2 Nov 2004 12:29:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 2 Nov 2004 12:29:45 -0000 Received: (qmail 67395 invoked by uid 500); 2 Nov 2004 12:29:37 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 67229 invoked by uid 500); 2 Nov 2004 12:29:36 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@geronimo.apache.org Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 67215 invoked by uid 99); 2 Nov 2004 12:29:36 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [192.18.33.10] (HELO exchange.sun.com) (192.18.33.10) by apache.org (qpsmtpd/0.28) with SMTP; Tue, 02 Nov 2004 04:29:34 -0800 Received: (qmail 9736 invoked from network); 2 Nov 2004 12:29:33 -0000 Received: from localhost (HELO nagoya) (127.0.0.1) by nagoya.betaversion.org with SMTP; 2 Nov 2004 12:29:33 -0000 Message-ID: <969967580.1099398573312.JavaMail.apache@nagoya> Date: Tue, 2 Nov 2004 04:29:33 -0800 (PST) From: "Alan Cabrera (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Assigned: (GERONIMO-421) Better handling for null/empty users in default LoginModules In-Reply-To: <361374647.1099372113641.JavaMail.apache@nagoya> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N [ http://nagoya.apache.org/jira/browse/GERONIMO-421?page=history ] Alan Cabrera reassigned GERONIMO-421: ------------------------------------- Assign To: Alan Cabrera > Better handling for null/empty users in default LoginModules > ------------------------------------------------------------ > > Key: GERONIMO-421 > URL: http://nagoya.apache.org/jira/browse/GERONIMO-421 > Project: Apache Geronimo > Type: Bug > Components: security > Versions: 1.0-M2 > Reporter: Aaron Mulder > Assignee: Alan Cabrera > > The PropertiesFileLoginModule throws an assertion error if no username is provided. I think this should just return false (or worst case, throw a regular LoginException) instead. I expect it to be unusual that the username would be null, but if so, it's just a plain failed login, right? > The SQLLoginModule doesn't seem to check at all, and would throw a NullPointerException if the user was null. Whatever we decide on the other one, we should do it here too. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://nagoya.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira