Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: neutral (hermes.apache.org: local policy)
Mime-Version: 1.0 (Apple Message framework v619)
In-Reply-To: <7AC82B4E-1559-11D9-B927-000D93C5B79C@gluecode.com>
References: <Pine.LNX.4.58.0410022244010.4765@saturn.opentools.org>
 <7AC82B4E-1559-11D9-B927-000D93C5B79C@gluecode.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <C1233D7E-1612-11D9-ADC6-000A95D41A40@apache.org>
Content-Transfer-Encoding: 7bit
From: Geir Magnusson Jr. <geirm@apache.org>
Subject: Re: Silent Connector Work Failure
Date: Mon, 4 Oct 2004 10:36:18 -0400
To: dev@geronimo.apache.org


On Oct 3, 2004, at 12:30 PM, Dain Sundstrom wrote:

> On Oct 2, 2004, at 7:49 PM, Aaron Mulder wrote:
>
>> 	I hesitate to admit how much time I just spent debugging a failure
>> with my connector.  The problem was that I was creating a Work that 
>> was
>> getting a NoClassDefFoundError while it ran, and I hadn't set a
>> WorkListener on it, so the exception was never reported.  (See
>> WorkerContext:290 where the only thing done with the exception is to 
>> pass
>> it to a listener).
>>
>> 	Does anyone mind if I put a message in there so if an exception
>> arises, the console prints "Exception while running Work: 
>> "+e.getMessage()
>> or something along those lines?  If we want to minimize output, I can 
>> do
>> that if and only if workListener == NULL_WORK_ADAPTER, but however 
>> it's
>> done, it would really help to get some indication from the server that
>> something went wrong with the application.
>
> I propose we simple change the declaration of NULL_WORK_ADAPTER to 
> something like this:
>
> private static final WorkListener NULL_WORK_LISTENER = new 
> WorkAdapter(){
>     public void workRejected(WorkEvent event) {
>         log.error(event.getWork().toString(), event.getException());
>     }
> };
>

I was going to suggest something along those lines...

+1

geir

> -dain
>
>
-- 
Geir Magnusson Jr                                  +1-203-665-6437
geirm@apache.org