Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <1292055776.1091141561790.JavaMail.apache@nagoya>
Date: Thu, 29 Jul 2004 15:52:41 -0700 (PDT)
From: dev@geronimo.apache.org
To: dev@geronimo.apache.org
Subject: [jira] Closed: (GERONIMO-255) GBeanMBean ManagedObject operations
 don't reliably replace GBean methods of the same name/signature
In-Reply-To: <1352169139.1088148134594.JavaMail.apache@nagoya>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Message:

   The following issue has been closed.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/GERONIMO-255

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: GERONIMO-255
    Summary: GBeanMBean ManagedObject operations don't reliably replace GBean methods of the same name/signature
       Type: Bug

     Status: Closed
   Priority: Critical
 Resolution: FIXED

    Project: Apache Geronimo
 Components: 
             core
   Fix Fors:
             1.0-M2
   Versions:
             1.0-M1

   Assignee: Dain Sundstrom
   Reporter: David Jencks

    Created: Fri, 25 Jun 2004 12:21 AM
    Updated: Thu, 29 Jul 2004 3:52 PM

Description:
When setting up operations for a GBean, the GBeanMBeanOperation are put into a set.  This has 2 problems if the GBean implements one of the operations from AbstractManagedObject:

1. Since GBeanMBeanOperation doesn't reimplement equals or hashCode, both operations get in the operationSet. It is entirely random which one gets installed as the real operation.

2. Even if GBeanMBeanOperation is modified to implement equals and hashCode based on method signature, set.add doesn't replace equal elements.  Therefore the method from the GBean overrides the method from AbstractManagedObject.

I've fixed this by using a operationMap from signature to GBeanMBeanOperation, similar to the attributeMap.  I'd appreciate a review.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira