Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Subject: RE: Checkstyle template -- feedback wanted
Date: Mon, 14 Jun 2004 06:52:11 -0400
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
Message-ID: <FF7CE36846E01B439945B55FFB1DF5BE03B2A7@customer.panix.com>
content-class: urn:content-classes:message
Thread-Topic: Checkstyle template -- feedback wanted
Thread-Index: AcRR/HF3DLKvZxrnQyyZEcs55zeH7gAASk5w
From: "Alan D. Cabrera" <adc@toolazydogs.com>
To: <dev@geronimo.apache.org>

David,

Site builds are still broken.


Regards,
Alan

> -----Original Message-----
> From: David Jencks [mailto:david@coredevelopers.net]
> Sent: Saturday, June 12, 2004 2:06 PM
> To: dev@geronimo.apache.org
> Subject: Checkstyle template -- feedback wanted
>=20
> After actually looking at the Checkstyle report for the connector
> module, I noticed that it was complaining about several things the
> Geronimo team and I in particular seem to regard as good coding
> practices.  Therefore I set up a customized geronimo_checks.xml in etc
> and pointed to it in global.properties.
>=20
> My changes consist of:
>=20
> --allowing lines up to 120 characters.
>=20
> --allowing "hiding variables" in constructor arguments and setters.
>=20
> --disabling the "design for extension" check.
>=20
> The reference for what can be checked is here:
> http://checkstyle.sourceforge.net/config.html#treewalkerchecks
>=20
> I'd appreciate any comments/complaints/suggestions.
>=20
> Another check we might want to consider the impact of is
> FinalLocalVariable
>
http://checkstyle.sourceforge.net/config_coding.html#FinalLocalVariable
>=20
> This appeared to be on in the default template, although I don't see
> the configuration in my copy.
>=20
>=20
> Thanks,
> David Jencks
>=20
>=20
>=20