geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan D. Cabrera" <...@toolazydogs.com>
Subject RE: Checkstyle template -- feedback wanted
Date Mon, 14 Jun 2004 10:52:11 GMT
David,

Site builds are still broken.


Regards,
Alan

> -----Original Message-----
> From: David Jencks [mailto:david@coredevelopers.net]
> Sent: Saturday, June 12, 2004 2:06 PM
> To: dev@geronimo.apache.org
> Subject: Checkstyle template -- feedback wanted
> 
> After actually looking at the Checkstyle report for the connector
> module, I noticed that it was complaining about several things the
> Geronimo team and I in particular seem to regard as good coding
> practices.  Therefore I set up a customized geronimo_checks.xml in etc
> and pointed to it in global.properties.
> 
> My changes consist of:
> 
> --allowing lines up to 120 characters.
> 
> --allowing "hiding variables" in constructor arguments and setters.
> 
> --disabling the "design for extension" check.
> 
> The reference for what can be checked is here:
> http://checkstyle.sourceforge.net/config.html#treewalkerchecks
> 
> I'd appreciate any comments/complaints/suggestions.
> 
> Another check we might want to consider the impact of is
> FinalLocalVariable
>
http://checkstyle.sourceforge.net/config_coding.html#FinalLocalVariable
> 
> This appeared to be on in the default template, although I don't see
> the configuration in my copy.
> 
> 
> Thanks,
> David Jencks
> 
> 
> 


Mime
View raw message