geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Jencks <da...@coredevelopers.net>
Subject Re: Checkstyle template -- feedback wanted
Date Mon, 14 Jun 2004 18:21:30 GMT
Which maven version are you using for the site builds?

My experience here is that rc3 works on os X and linux and rc1 fails on 
linux.  If you are on a pre-rc3 version would it be possibly for you to 
upgrade?

thanks
david jencks

On Monday, June 14, 2004, at 03:52 AM, Alan D. Cabrera wrote:

> David,
>
> Site builds are still broken.
>
>
> Regards,
> Alan
>
>> -----Original Message-----
>> From: David Jencks [mailto:david@coredevelopers.net]
>> Sent: Saturday, June 12, 2004 2:06 PM
>> To: dev@geronimo.apache.org
>> Subject: Checkstyle template -- feedback wanted
>>
>> After actually looking at the Checkstyle report for the connector
>> module, I noticed that it was complaining about several things the
>> Geronimo team and I in particular seem to regard as good coding
>> practices.  Therefore I set up a customized geronimo_checks.xml in etc
>> and pointed to it in global.properties.
>>
>> My changes consist of:
>>
>> --allowing lines up to 120 characters.
>>
>> --allowing "hiding variables" in constructor arguments and setters.
>>
>> --disabling the "design for extension" check.
>>
>> The reference for what can be checked is here:
>> http://checkstyle.sourceforge.net/config.html#treewalkerchecks
>>
>> I'd appreciate any comments/complaints/suggestions.
>>
>> Another check we might want to consider the impact of is
>> FinalLocalVariable
>>
> http://checkstyle.sourceforge.net/config_coding.html#FinalLocalVariable
>>
>> This appeared to be on in the default template, although I don't see
>> the configuration in my copy.
>>
>>
>> Thanks,
>> David Jencks
>>
>>
>>
>


Mime
View raw message